refactor: flags in bfs

Author: IgorErin

src/GraphBLAS-sharp.Backend/Algorithms/BFS.fs

@@ -8,6 +8,7 @@ open GraphBLAS.FSharp.Backend.Common
 open GraphBLAS.FSharp.Backend.Quotes
 open GraphBLAS.FSharp.Backend.Vector
 open GraphBLAS.FSharp.Backend.Vector.Dense
+open GraphBLAS.FSharp.Backend.Objects.ClContext
 open GraphBLAS.FSharp.Backend.Objects.ArraysExtensions
 
 module BFS =
@@ -24,7 +25,7 @@ module BFS =
         let zeroCreate =
             ClArray.zeroCreate clContext workGroupSize
 
-        let ofList = Vector.ofList clContext Dense
+        let ofList = Vector.ofList clContext workGroupSize
 
         let maskComplementedTo =
             DenseVector.elementWiseTo clContext Mask.complementedMaskOp workGroupSize
@@ -40,7 +41,8 @@ module BFS =
 
             let levels = zeroCreate queue vertexCount
 
-            let frontier = ofList vertexCount [ source, 1 ]
+            let frontier =
+                ofList queue Dense GPUOnly vertexCount [ source, 1 ]
 
             match frontier with
             | ClVector.Dense front ->

src/GraphBLAS-sharp.Backend/Objects/ClContextExtensions.fs

@@ -8,7 +8,7 @@ module ClContext =
         | CPUInterop
 
     type ClContext with
-        member this.CreateClArrayWithFlag(mode, (size: int)) =
+        member this.CreateClArrayWithFlag(mode, size: int) =
             match mode with
             | GPUOnly ->
                 this.CreateClArray(
@@ -25,7 +25,7 @@ module ClContext =
                     allocationMode = AllocationMode.Default
                 )
 
-        member this.CreateClArrayWithFlag(mode, (array: 'a [])) =
+        member this.CreateClArrayWithFlag(mode, array: 'a []) =
             match mode with
             | GPUOnly ->
                 this.CreateClArray(

src/GraphBLAS-sharp.Backend/Vector/Vector.fs

@@ -17,7 +17,7 @@ module Vector =
         let zeroCreate =
             ClArray.zeroCreate clContext workGroupSize
 
-        fun (processor: MailboxProcessor<_>) (size: int) (format: VectorFormat) (flag: AllocationFlag) ->
+        fun (processor: MailboxProcessor<_>) size format flag ->
             match format with
             | Sparse ->
                 ClVector.Sparse
@@ -35,7 +35,7 @@ module Vector =
         let map =
             ClArray.map clContext workGroupSize <@ Some @>
 
-        fun (processor: MailboxProcessor<_>) (format: VectorFormat) flag size (elements: (int * 'a) list) ->
+        fun (processor: MailboxProcessor<_>) format flag size (elements: (int * 'a) list) ->
             let indices, values =
                 elements
                 |> Array.ofList

tests/GraphBLAS-sharp.Tests/Vector/OfList.fs

@@ -32,7 +32,7 @@ let checkResult
 
 let correctnessGenericTest<'a when 'a: struct>
     (isEqual: 'a -> 'a -> bool)
-    (ofList: VectorFormat -> int -> (int * 'a) list -> ClVector<'a>)
+    (ofList: MailboxProcessor<_> -> VectorFormat -> ClContext.AllocationFlag -> int -> (int * 'a) list -> ClVector<'a>)
     (toCoo: MailboxProcessor<_> -> ClVector<'a> -> ClVector<'a>)
     (case: OperationCase<VectorFormat>)
     (elements: (int * 'a) [])
@@ -54,7 +54,8 @@ let correctnessGenericTest<'a when 'a: struct>
 
         let actualSize = (Array.max indices) + abs sizeDelta + 1
 
-        let clActual = ofList case.Format actualSize elements
+        let clActual =
+            ofList q case.Format ClContext.CPUInterop actualSize elements
 
         let clCooActual = toCoo q clActual
 
@@ -78,15 +79,15 @@ let testFixtures (case: OperationCase<VectorFormat>) =
       let getCorrectnessTestName datatype =
           sprintf "Correctness on %s, %A" datatype case.Format
 
-      let boolOfList = Vector.ofList context
+      let boolOfList = Vector.ofList context wgSize
 
       let toCoo = Vector.toSparse context wgSize
 
       case
       |> correctnessGenericTest<bool> (=) boolOfList toCoo
       |> testPropertyWithConfig config (getCorrectnessTestName "bool")
 
-      let intOfList = Vector.ofList context
+      let intOfList = Vector.ofList context wgSize
 
       let toCoo = Vector.toSparse context wgSize
 
@@ -95,15 +96,15 @@ let testFixtures (case: OperationCase<VectorFormat>) =
       |> testPropertyWithConfig config (getCorrectnessTestName "int")
 
 
-      let byteOfList = Vector.ofList context
+      let byteOfList = Vector.ofList context wgSize
 
       let toCoo = Vector.toSparse context wgSize
 
       case
       |> correctnessGenericTest<byte> (=) byteOfList toCoo
       |> testPropertyWithConfig config (getCorrectnessTestName "byte")
 
-      let floatOfList = Vector.ofList context
+      let floatOfList = Vector.ofList context wgSize
 
       let toCoo = Vector.toSparse context wgSize
 

tests/GraphBLAS-sharp.Tests/Vector/ZeroCreate.fs

@@ -27,15 +27,16 @@ let checkResult size (actual: Vector<'a>) =
         Expect.equal vector.Indices [| 0 |] "The index array must contain the 0"
 
 let correctnessGenericTest<'a when 'a: struct and 'a: equality>
-    (zeroCreate: MailboxProcessor<_> -> int -> VectorFormat -> ClVector<'a>)
+    (zeroCreate: MailboxProcessor<_> -> int -> VectorFormat -> ClContext.AllocationFlag -> ClVector<'a>)
     (case: OperationCase<VectorFormat>)
     (vectorSize: int)
     =
 
     if vectorSize > 0 then
         let q = case.TestContext.Queue
 
-        let (clVector: ClVector<'a>) = zeroCreate q vectorSize case.Format
+        let (clVector: ClVector<'a>) =
+            zeroCreate q vectorSize case.Format ClContext.CPUInterop
 
         let hostVector = clVector.ToHost q