Various bug fixes

Author: skuroda

advanced_new_file/commands/command_base.py

@@ -261,7 +261,7 @@ def entered_filename(self, filename):
         file_path = generate_creation_path(self.settings, base, path, True)
         # Check for invalid alias specified.
         is_valid = (TOP_LEVEL_SPLIT_CHAR in filename and
-                    self.platform.is_absolute_path(base))
+                    not self.platform.is_absolute_path(base))
         if is_valid:
             if base == "":
                 error_message = "Current file cannot be resolved."

advanced_new_file/commands/delete_file_command.py

@@ -62,6 +62,6 @@ def _delete_file(self, filepath):
         file_view = self._find_open_file(filepath)
         if file_view is not None:
             file_view.set_scratch(True)
-            window.focus_view(file_view)
-            window.run_command("close")
+            self.window.focus_view(file_view)
+            self.window.run_command("close")
         self.refresh_sidebar()

advanced_new_file/commands/git/git_command_base.py

@@ -11,6 +11,7 @@ def _test_paths_for_executable(paths, test_file):
         if os.path.exists(file_path) and os.access(file_path, os.X_OK):
             return file_path
 
+
 def find_git():
     # It turns out to be difficult to reliably run git, with varying paths
     # and subprocess environments across different platforms. So. Let's hack
@@ -42,6 +43,7 @@ def find_git():
 
 GIT = find_git()
 
+
 # Base for git commands
 class GitCommandBase(object):
     def __init__(self, window):
@@ -52,11 +54,11 @@ def file_tracked_by_git(self, filepath):
         git = GIT
         if git is not None:
             path, file_name = os.path.split(filepath)
-            return self.run_command(["ls-files", file_name, "--error-unmatch"], path) == 0
+            return self.run_command(
+                ["ls-files", file_name, "--error-unmatch"], path) == 0
         else:
             return False
 
     def run_command(self, args, cwd):
         use_shell = PLATFORM == "windows"
         return subprocess.call([GIT] + args, cwd=cwd, shell=use_shell)
-

advanced_new_file/commands/move_file_command.py

@@ -21,11 +21,11 @@ def run(self, is_python=False, initial_path=None, rename_file=None):
         path = self.settings.get(RENAME_DEFAULT_SETTING)
         current_file = self.view.file_name()
         if current_file:
+            path = path.replace("<filepath>", current_file)
             current_file_name = os.path.basename(self.view.file_name())
         else:
             current_file_name = ""
 
-        path = path.replace("<filepath>", current_file)
         path = path.replace("<filename>", current_file_name)
         self.show_filename_input(
             path if len(path) > 0 else self.generate_initial_path())

advanced_new_file/completions/completion_base.py

@@ -15,7 +15,7 @@ def __init__(self, command):
     def is_home(self, path):
         return re.match(r"^~[/\\]", path)
 
-    def is_alias(self, path_):
+    def is_alias(self, path):
         return self.top_level_split_char in path
 
     def generate_completion_list(self, path_in):