Skip to content

Commit 9351db8

Browse files
committed
fix: small tweak to Spam Filter Policy
1 parent 3c12359 commit 9351db8

1 file changed

Lines changed: 12 additions & 13 deletions

File tree

Modules/CIPPCore/Public/Standards/Invoke-CIPPStandardSpamFilterPolicy.ps1

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -115,47 +115,46 @@ function Invoke-CIPPStandardSpamFilterPolicy {
115115
try {
116116
$cmdparams.Add('Identity', $PolicyName)
117117
New-ExoRequest -TenantId $Tenant -cmdlet 'Set-HostedContentFilterPolicy' -cmdparams $cmdparams -UseSystemMailbox $true
118-
Write-LogMessage -API 'Standards' -Tenant $Tenant -message 'Updated Spam Filter Policy' -sev Info
118+
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Updated Spam Filter policy $PolicyName." -sev Info
119119
} catch {
120-
$ErrorMessage = Get-NormalizedError -Message $_.Exception.Message
121-
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Failed to update Spam Filter Policy. Error: $ErrorMessage" -sev Error
120+
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Failed to update Spam Filter policy $PolicyName." -sev Error -LogData $_
122121
}
123122
} else {
124123
try {
125124
$cmdparams.Add('Name', $PolicyName)
126125
New-ExoRequest -TenantId $Tenant -cmdlet 'New-HostedContentFilterPolicy' -cmdparams $cmdparams -UseSystemMailbox $true
127-
Write-LogMessage -API 'Standards' -Tenant $Tenant -message 'Created Spam Filter Policy' -sev Info
126+
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Created Spam Filter policy $PolicyName." -sev Info
128127
} catch {
129-
$ErrorMessage = Get-NormalizedError -Message $_.Exception.Message
130-
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Failed to create Spam Filter Policy. Error: $ErrorMessage" -sev Error
128+
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Failed to create Spam Filter policy $PolicyName." -sev Error -LogData $_
131129
}
132130
}
133131
}
134132

135133
if ($RuleStateIsCorrect -eq $false) {
136134
$cmdparams = @{
137-
HostedContentFilterPolicy = $PolicyName
138135
Priority = 0
139136
RecipientDomainIs = $AcceptedDomains.Name
140137
}
141138

139+
if ($RuleState.HostedContentFilterPolicy -ne $PolicyName) {
140+
$cmdparams.Add('HostedContentFilterPolicy', $PolicyName)
141+
}
142+
142143
if ($RuleState.Name -eq $PolicyName) {
143144
try {
144145
$cmdparams.Add('Identity', "$PolicyName")
145146
New-ExoRequest -TenantId $Tenant -cmdlet 'Set-HostedContentFilterRule' -cmdparams $cmdparams -UseSystemMailbox $true
146-
Write-LogMessage -API 'Standards' -Tenant $Tenant -message 'Updated Spam Filter Rule' -sev Info
147+
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Updated Spam Filter rule $PolicyName." -sev Info
147148
} catch {
148-
$ErrorMessage = Get-NormalizedError -Message $_.Exception.Message
149-
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Failed to update Spam Filter Rule. Error: $ErrorMessage" -sev Error
149+
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Failed to update Spam Filter rule $PolicyName." -sev Error -LogData $_
150150
}
151151
} else {
152152
try {
153153
$cmdparams.Add('Name', "$PolicyName")
154154
New-ExoRequest -TenantId $Tenant -cmdlet 'New-HostedContentFilterRule' -cmdparams $cmdparams -UseSystemMailbox $true
155-
Write-LogMessage -API 'Standards' -Tenant $Tenant -message 'Created Spam Filter Rule' -sev Info
155+
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Created Spam Filter rule $PolicyName." -sev Info
156156
} catch {
157-
$ErrorMessage = Get-NormalizedError -Message $_.Exception.Message
158-
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Failed to create Spam Filter Rule. Error: $ErrorMessage" -sev Error
157+
Write-LogMessage -API 'Standards' -Tenant $Tenant -message "Failed to create Spam Filter rule $PolicyName." -sev Error -LogData $_
159158
}
160159
}
161160
}

0 commit comments

Comments
 (0)