test(svelte-query): replace inline props types with 'type Props', remove 'any', and add explicit generics (#10448)

sukvvon · web-flow · commit ee5b574b2dea · 2026-04-11T16:44:10.000+09:00
diff --git a/packages/svelte-query/tests/HydrationBoundary/BaseExample.svelte b/packages/svelte-query/tests/HydrationBoundary/BaseExample.svelte
@@ -7,15 +7,13 @@
   } from '../../src/index.js'
   import type { DehydratedState } from '@tanstack/query-core'
 
-  let {
-    queryClient,
-    dehydratedState,
-    queryFn,
-  }: {
+  type Props = {
     queryClient: QueryClient
     dehydratedState: DehydratedState
     queryFn: () => Promise<string>
-  } = $props()
+  }
+
+  let { queryClient, dehydratedState, queryFn }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte b/packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte
@@ -3,7 +3,11 @@
   import QueryChild from './QueryChild.svelte'
   import type { QueryClient } from '@tanstack/query-core'
 
-  let { queryClient }: { queryClient: QueryClient } = $props()
+  type Props = {
+    queryClient: QueryClient
+  }
+
+  let { queryClient }: Props = $props()
 </script>
 
 <QueryClientProvider client={queryClient}>
diff --git a/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte b/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte
@@ -5,13 +5,12 @@
   import { setQueryClientContext } from '../../src/context.js'
   import type { QueryClient, QueryObserverResult } from '@tanstack/query-core'
 
-  let {
-    queryClient,
-    states,
-  }: {
+  type Props = {
     queryClient: QueryClient
     states: { value: Array<QueryObserverResult> }
-  } = $props()
+  }
+
+  let { queryClient, states }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte b/packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte
@@ -4,7 +4,11 @@
   import { setQueryClientContext } from '../../src/context.js'
   import { sleep } from '@tanstack/query-test-utils'
 
-  let { queryClient }: { queryClient: QueryClient } = $props()
+  type Props = {
+    queryClient: QueryClient
+  }
+
+  let { queryClient }: Props = $props()
 
   const queryKey = ['test']
 
diff --git a/packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte b/packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte
@@ -5,13 +5,12 @@
   import type { QueryClient, QueryObserverResult } from '@tanstack/query-core'
   import { queryKey, sleep } from '@tanstack/query-test-utils'
 
-  let {
-    queryClient,
-    states,
-  }: {
+  type Props = {
     queryClient: QueryClient
     states: { value: Array<QueryObserverResult> }
-  } = $props()
+  }
+
+  let { queryClient, states }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/createMutation/FailureExample.svelte b/packages/svelte-query/tests/createMutation/FailureExample.svelte
@@ -2,13 +2,12 @@
   import type { QueryClient } from '@tanstack/query-core'
   import { createMutation, setQueryClientContext } from '../../src/index.js'
 
-  let {
-    queryClient,
-    mutationFn,
-  }: {
+  type Props = {
     queryClient: QueryClient
     mutationFn: (value: { count: number }) => Promise<{ count: number }>
-  } = $props()
+  }
+
+  let { queryClient, mutationFn }: Props = $props()
 
   let count = $state(0)
 
diff --git a/packages/svelte-query/tests/createMutation/OnSuccessExample.svelte b/packages/svelte-query/tests/createMutation/OnSuccessExample.svelte
@@ -5,8 +5,8 @@
 
   type Props = {
     queryClient: QueryClient
-    onSuccessMock: any
-    onSettledMock: any
+    onSuccessMock: (data: number) => void
+    onSettledMock: (data: number | undefined) => void
   }
 
   const { queryClient, onSettledMock, onSuccessMock }: Props = $props()
diff --git a/packages/svelte-query/tests/createMutation/ResetExample.svelte b/packages/svelte-query/tests/createMutation/ResetExample.svelte
@@ -3,7 +3,11 @@
   import { createMutation, setQueryClientContext } from '../../src/index.js'
   import { sleep } from '@tanstack/query-test-utils'
 
-  let { queryClient }: { queryClient: QueryClient } = $props()
+  type Props = {
+    queryClient: QueryClient
+  }
+
+  let { queryClient }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte b/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte
@@ -7,15 +7,13 @@
   } from '../../src/context.js'
   import { createQueries } from '../../src/index.js'
 
-  let {
-    queryClient,
-    queryFn1,
-    queryFn2,
-  }: {
+  type Props = {
     queryClient: QueryClient
     queryFn1: () => Promise<string>
     queryFn2: () => Promise<string>
-  } = $props()
+  }
+
+  let { queryClient, queryFn1, queryFn2 }: Props = $props()
 
   setQueryClientContext(queryClient)
   setIsRestoringContext({ current: true })
diff --git a/packages/svelte-query/tests/createQuery/IsRestoringExample.svelte b/packages/svelte-query/tests/createQuery/IsRestoringExample.svelte
@@ -7,13 +7,12 @@
   } from '../../src/context.js'
   import { createQuery } from '../../src/index.js'
 
-  let {
-    queryClient,
-    queryFn,
-  }: {
+  type Props = {
     queryClient: QueryClient
     queryFn: () => Promise<string>
-  } = $props()
+  }
+
+  let { queryClient, queryFn }: Props = $props()
 
   setQueryClientContext(queryClient)
   setIsRestoringContext({ current: true })
diff --git a/packages/svelte-query/tests/mutationOptions/BaseExample.svelte b/packages/svelte-query/tests/mutationOptions/BaseExample.svelte
@@ -13,17 +13,19 @@
   } from '../../src/index.js'
   import type { MutationFilters } from '@tanstack/query-core'
 
+  type Props = {
+    queryClient: QueryClient
+    mutationOpts: Accessor<CreateMutationOptions<string>>
+    isMutatingFilters?: MutationFilters
+    mutationStateOpts?: MutationStateOptions
+  }
+
   let {
     queryClient,
     mutationOpts,
     isMutatingFilters,
     mutationStateOpts,
-  }: {
-    queryClient: QueryClient
-    mutationOpts: Accessor<CreateMutationOptions<string, Error, void, unknown>>
-    isMutatingFilters?: MutationFilters
-    mutationStateOpts?: MutationStateOptions
-  } = $props()
+  }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/mutationOptions/MultiExample.svelte b/packages/svelte-query/tests/mutationOptions/MultiExample.svelte
@@ -13,19 +13,21 @@
   } from '../../src/index.js'
   import type { MutationFilters } from '@tanstack/query-core'
 
+  type Props = {
+    queryClient: QueryClient
+    mutationOpts1: Accessor<CreateMutationOptions<string>>
+    mutationOpts2: Accessor<CreateMutationOptions<string>>
+    isMutatingFilters?: MutationFilters
+    mutationStateOpts?: MutationStateOptions
+  }
+
   let {
     queryClient,
     mutationOpts1,
     mutationOpts2,
     isMutatingFilters,
     mutationStateOpts,
-  }: {
-    queryClient: QueryClient
-    mutationOpts1: Accessor<CreateMutationOptions<string, Error, void, unknown>>
-    mutationOpts2: Accessor<CreateMutationOptions<string, Error, void, unknown>>
-    isMutatingFilters?: MutationFilters
-    mutationStateOpts?: MutationStateOptions
-  } = $props()
+  }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/useIsFetching/BaseExample.svelte b/packages/svelte-query/tests/useIsFetching/BaseExample.svelte
@@ -4,7 +4,11 @@
   import { setQueryClientContext } from '../../src/context.js'
   import { createQuery, useIsFetching } from '../../src/index.js'
 
-  let { queryClient }: { queryClient: QueryClient } = $props()
+  type Props = {
+    queryClient: QueryClient
+  }
+
+  let { queryClient }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/useIsMutating/BaseExample.svelte b/packages/svelte-query/tests/useIsMutating/BaseExample.svelte
@@ -4,7 +4,11 @@
   import { setQueryClientContext } from '../../src/context.js'
   import { createMutation, useIsMutating } from '../../src/index.js'
 
-  let { queryClient }: { queryClient: QueryClient } = $props()
+  type Props = {
+    queryClient: QueryClient
+  }
+
+  let { queryClient }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/useMutationState/BaseExample.svelte b/packages/svelte-query/tests/useMutationState/BaseExample.svelte
@@ -11,17 +11,19 @@
     MutationStateOptions,
   } from '../../src/index.js'
 
+  type Props = {
+    queryClient: QueryClient
+    successMutationOpts: Accessor<CreateMutationOptions<string>>
+    errorMutationOpts: Accessor<CreateMutationOptions<string>>
+    mutationStateOpts?: MutationStateOptions
+  }
+
   let {
     queryClient,
     successMutationOpts,
     errorMutationOpts,
     mutationStateOpts,
-  }: {
-    queryClient: QueryClient
-    successMutationOpts: Accessor<CreateMutationOptions>
-    errorMutationOpts: Accessor<CreateMutationOptions>
-    mutationStateOpts?: MutationStateOptions | undefined
-  } = $props()
+  }: Props = $props()
 
   setQueryClientContext(queryClient)
 
diff --git a/packages/svelte-query/tests/useMutationState/SelectExample.svelte b/packages/svelte-query/tests/useMutationState/SelectExample.svelte
@@ -11,15 +11,13 @@
     MutationStateOptions,
   } from '../../src/index.js'
 
-  let {
-    queryClient,
-    mutationOpts,
-    mutationStateOpts,
-  }: {
+  type Props = {
     queryClient: QueryClient
-    mutationOpts: Accessor<CreateMutationOptions>
-    mutationStateOpts: MutationStateOptions<any>
-  } = $props()
+    mutationOpts: Accessor<CreateMutationOptions<string>>
+    mutationStateOpts: MutationStateOptions<string>
+  }
+
+  let { queryClient, mutationOpts, mutationStateOpts }: Props = $props()
 
   setQueryClientContext(queryClient)
 

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,8 @@`
`5`	`5`
`6`	`6`	`type Props = {`
`7`	`7`	`queryClient: QueryClient`
`8`		`- onSuccessMock: any`
`9`		`- onSettledMock: any`
	`8`	`+ onSuccessMock: (data: number) => void`
	`9`	`+ onSettledMock: (data: number \| undefined) => void`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`const { queryClient, onSettledMock, onSuccessMock }: Props = $props()`