Skip to content

Commit dfa3539

Browse files
authored
🤖 Merge PR DefinitelyTyped#74341 [oracledb] Fix Sessionless Transactions methods to return Promises by @sosoba
1 parent ef421fe commit dfa3539

2 files changed

Lines changed: 14 additions & 7 deletions

File tree

‎types/oracledb/index.d.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1302,7 +1302,9 @@ declare namespace OracleDB {
13021302
*
13031303
* @since 6.9
13041304
*/
1305-
beginSessionlessTransaction(opts: SessionlessTransactionOpts): SessionlessTransactionOpts["transactionId"];
1305+
beginSessionlessTransaction(
1306+
opts: SessionlessTransactionOpts,
1307+
): Promise<SessionlessTransactionOpts["transactionId"]>;
13061308
beginSessionlessTransaction(opts: SessionlessTransactionOpts, callback: (error: DBError) => void): void;
13071309
/**
13081310
* Stops the currently running operation on the connection.
@@ -1681,7 +1683,7 @@ declare namespace OracleDB {
16811683
resumeSessionlessTransaction(
16821684
transactionId: SessionlessTransactionOpts["transactionId"],
16831685
resTxnOpts?: ResumeSessionlessTxnOpts,
1684-
): SessionlessTransactionOpts["transactionId"];
1686+
): Promise<SessionlessTransactionOpts["transactionId"]>;
16851687
resumeSessionlessTransaction(callback: (error: DBError) => void): void;
16861688
/**
16871689
* Rolls back the current transaction in progress on the connection.
@@ -1760,7 +1762,7 @@ declare namespace OracleDB {
17601762
*
17611763
* @since 6.9
17621764
*/
1763-
suspendSessionlessTransaction(): void;
1765+
suspendSessionlessTransaction(): Promise<void>;
17641766
suspendSessionlessTransaction(callback: (error: DBError) => void): void;
17651767
/**
17661768
* Unregister a Continuous Query Notification (CQN) subscription previously created with connection.subscribe().

‎types/oracledb/oracledb-tests.ts‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -822,11 +822,16 @@ export const version6_9Tests = async (): Promise<void> => {
822822
});
823823

824824
const txnId = "testId";
825-
await connection.beginSessionlessTransaction({ transactionId: txnId, timeout: 2, deferRoundTrip: true });
825+
const id1 = await connection.beginSessionlessTransaction({
826+
transactionId: txnId,
827+
timeout: 2,
828+
deferRoundTrip: true,
829+
});
830+
console.log(id1.length);
826831
await connection.execute("INSERT INTO TEST VALUES(1)", {}, { suspendOnSuccess: true });
827-
await connection.suspendSessionlessTransaction();
828-
await connection.resumeSessionlessTransaction(txnId, { deferRoundTrip: false });
829-
832+
await connection.suspendSessionlessTransaction().then();
833+
const id2 = await connection.resumeSessionlessTransaction(txnId, { deferRoundTrip: false });
834+
console.log(id2.length);
830835
console.log(connection.ltxid);
831836

832837
await oracledb.createPool({

0 commit comments

Comments
 (0)