Skip to content

Commit ff29322

Browse files
authored
🤖 Merge PR DefinitelyTyped#74884 [@types/pdfkit] Replace NodeJS.ReadableStream type with stream.Readable by @7hokerz
1 parent 0410819 commit ff29322

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

‎types/pdfkit/index.d.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
/// <reference types="node" />
22

3+
type PDFKitReadable = import("stream").Readable;
4+
35
declare namespace PDFKit {
46
interface PDFGradient {
57
new(document: any): PDFGradient;
@@ -862,7 +864,7 @@ declare namespace PDFKit {
862864

863865
interface PDFDocument
864866
extends
865-
NodeJS.ReadableStream,
867+
PDFKitReadable,
866868
Mixins.PDFMetadata,
867869
Mixins.PDFAnnotation,
868870
Mixins.PDFColor,

‎types/pdfkit/pdfkit-tests.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import mtext = require("pdfkit/js/mixins/text");
1010

1111
import PDFDocument = require("pdfkit");
1212
import PDFDocumentStandalone = require("pdfkit/js/pdfkit.standalone");
13+
import stream = require("stream");
1314

1415
import font = require("pdfkit/js/mixins/fonts");
1516
import pdfData = require("pdfkit/js/data");
@@ -34,6 +35,15 @@ var doc: PDFKit.PDFDocument = new PDFDocument({
3435
fontLayoutCache: true,
3536
});
3637

38+
const readable: stream.Readable = doc;
39+
40+
// $ExpectType PDFDocument
41+
doc.destroy();
42+
// $ExpectType boolean
43+
doc.destroyed;
44+
// $ExpectType boolean
45+
doc.readableEnded;
46+
3747
// $ExpectType PDFDocument
3848
doc.addPage();
3949
// $ExpectType PDFDocument

0 commit comments

Comments
 (0)