fix: reset static fields for Fast Enter Play Mode

Author: noellie-velez

com.unity.netcode.gameobjects/Runtime/Components/NetworkAnimator.cs

@@ -706,7 +706,6 @@ protected virtual bool OnIsServerAuthoritative()
         private int[] m_TransitionHash;
         private int[] m_AnimationHash;
         private float[] m_LayerWeights;
-        private static byte[] s_EmptyArray = new byte[] { };
         private List<int> m_ParametersToUpdate;
         private RpcParams m_RpcParams;
         private IGroupRpcTarget m_TargetGroup;

com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs

@@ -2221,13 +2221,11 @@ private bool CheckForStateChange(ref NetworkTransformState networkState, bool is
                 // values are applied.
                 var hasParentNetworkObject = false;
 
-                var parentNetworkObject = (NetworkObject)null;
-
                 // If the NetworkObject belonging to this NetworkTransform instance has a parent
                 // (i.e. this handles nested NetworkTransforms under a parent at some layer above)
                 if (NetworkObject.transform.parent != null)
                 {
-                    parentNetworkObject = NetworkObject.transform.parent.GetComponent<NetworkObject>();
+                    var parentNetworkObject = NetworkObject.transform.parent.GetComponent<NetworkObject>();
 
                     // In-scene placed NetworkObjects parented under a GameObject with no
                     // NetworkObject preserve their lossyScale when synchronizing.
@@ -4800,6 +4798,21 @@ public NetworkTransformTickRegistration(NetworkManager networkManager)
             }
         }
         private static int s_TickSynchPosition;
+
+#if UNITY_EDITOR
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
+        private static void ResetStaticsOnLoad()
+        {
+            CurrentTick = 0;
+            TrackStateUpdateId = false;
+            AssignDefaultInterpolationType = false;
+            DefaultInterpolationType = default;
+            s_NetworkTickRegistration = new Dictionary<NetworkManager, NetworkTransformTickRegistration>();
+            InterpolationBufferTickOffset = 0;
+            s_TickSynchPosition = 0;
+        }
+#endif
+
         private int m_NextTickSync;
 
         internal void RegisterForTickSynchronization()

com.unity.netcode.gameobjects/Runtime/Components/QuaternionCompressor.cs

@@ -44,6 +44,10 @@ public static class QuaternionCompressor
 
         // Used to store the absolute value of the 4 quaternion elements
         private static Quaternion s_QuatAbsValues = Quaternion.identity;
+#if UNITY_EDITOR
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
+        private static void ResetStaticsOnLoad() => s_QuatAbsValues = Quaternion.identity;
+#endif
 
         /// <summary>
         /// Compresses a Quaternion into an unsigned integer

com.unity.netcode.gameobjects/Runtime/Components/RigidbodyContactEventManager.cs

@@ -20,7 +20,7 @@ public struct ContactEventHandlerInfo
         /// </summary>
         public bool ProvideNonRigidBodyContactEvents;
         /// <summary>
-        /// When set to true, the <see cref="RigidbodyContactEventManager"/> will prioritize invoking <see cref="IContactEventHandler.ContactEvent(ulong, Vector3, Rigidbody, Vector3, bool, Vector3)"/> <br /></br>
+        /// When set to true, the <see cref="RigidbodyContactEventManager"/> will prioritize invoking <see cref="IContactEventHandler.ContactEvent(ulong, Vector3, Rigidbody, Vector3, bool, Vector3)"/> <br />
         /// if it is the 2nd colliding body in the contact pair being processed. With distributed authority, setting this value to true when a <see cref="NetworkObject"/> is owned by the local client <br />
         /// will assure <see cref="IContactEventHandler.ContactEvent(ulong, Vector3, Rigidbody, Vector3, bool, Vector3)"/> is only invoked on the authoritative side.
         /// </summary>
@@ -76,6 +76,10 @@ public interface IContactEventHandlerWithInfo : IContactEventHandler
     public class RigidbodyContactEventManager : MonoBehaviour
     {
         public static RigidbodyContactEventManager Instance { get; private set; }
+#if UNITY_EDITOR
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
+        private static void ResetStaticsOnLoad() => Instance = null;
+#endif
 
         private struct JobResultStruct
         {

com.unity.netcode.gameobjects/Runtime/Configuration/CommandLineOptions.cs

@@ -30,32 +30,32 @@ private set
         }
         private static CommandLineOptions s_Instance;
 
-        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
-        private static void RuntimeInitializeOnLoad() => Instance = new CommandLineOptions();
-
         // Contains the current application instance domain's command line arguments
-        internal static List<string> CommandLineArguments = new List<string>();
+        private static List<string> s_CommandLineArguments = new List<string>(Environment.GetCommandLineArgs());
 
-        // Invoked upon application start, after scene load
-        [RuntimeInitializeOnLoadMethod]
-        private static void ParseCommandLineArguments()
+#if UNITY_EDITOR
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
+        private static void ResetStaticsOnLoad()
         {
+            Instance = new CommandLineOptions();
+            s_Instance = new CommandLineOptions();
             // Get all the command line arguments to be parsed later and/or modified
             // prior to being parsed (for testing purposes).
-            CommandLineArguments = new List<string>(Environment.GetCommandLineArgs());
+            s_CommandLineArguments = new List<string>(Environment.GetCommandLineArgs());
         }
+#endif
 
         /// <summary>
-        /// Returns the value of an argument or null if there the argument is not present
+        /// Returns the value of an argument or null if the argument is not present
         /// </summary>
         /// <param name="arg">The name of the argument</param>
         /// <returns><see cref="string"/>Value of the command line argument passed in.</returns>
         public string GetArg(string arg)
         {
-            var argIndex = CommandLineArguments.IndexOf(arg);
-            if (argIndex >= 0 && argIndex < CommandLineArguments.Count - 1)
+            var argIndex = s_CommandLineArguments.IndexOf(arg);
+            if (argIndex >= 0 && argIndex < s_CommandLineArguments.Count - 1)
             {
-                return CommandLineArguments[argIndex + 1];
+                return s_CommandLineArguments[argIndex + 1];
             }
             return null;
         }

com.unity.netcode.gameobjects/Runtime/Core/ComponentFactory.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using UnityEngine;
 
 namespace Unity.Netcode
 {
@@ -14,6 +15,10 @@ internal static class ComponentFactory
         internal delegate object CreateObjectDelegate(NetworkManager networkManager);
 
         private static Dictionary<Type, CreateObjectDelegate> s_Delegates = new Dictionary<Type, CreateObjectDelegate>();
+#if UNITY_EDITOR
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
+        private static void ResetStaticsOnLoad() => s_Delegates = new Dictionary<Type, CreateObjectDelegate>();
+#endif
 
         /// <summary>
         /// Instantiates an instance of a given interface

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -1297,8 +1297,6 @@ internal void NetworkVariableUpdate(ulong targetClientId, bool forceSend = false
             }
         }
 
-        internal static bool LogSentVariableUpdateMessage;
-
         private bool CouldHaveDirtyNetworkVariables()
         {
             // TODO: There should be a better way by reading one dirty variable vs. 'n'

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -1809,6 +1809,19 @@ internal abstract class NetcodeAnalytics
         internal delegate void ResetNetworkManagerDelegate(NetworkManager manager);
 
         internal static ResetNetworkManagerDelegate OnNetworkManagerReset;
+        //We already are in an #if UNITY_ENGINE def
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
+        private static void ResetStaticsOnLoad()
+        {
+            Singleton = null;
+            OnInstantiated = null;
+            OnDestroying = null;
+            OnSingletonReady = null;
+            OnNetworkManagerReset = null;
+            IsDistributedAuthority = false;
+            s_SerializedType = new List<Type>();
+            DisableNotOptimizedSerializedType = false;
+        }
 
         private void Reset()
         {

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -1688,6 +1688,11 @@ public static void NetworkHide(List<NetworkObject> networkObjects, ulong clientI
             }
         }
 
+        private void OnDisable()
+        {
+            SceneManager.activeSceneChanged -= CurrentlyActiveSceneChanged;
+        }
+
         private void OnDestroy()
         {
             var networkManager = NetworkManager;
@@ -2449,6 +2454,10 @@ private void OnTransformParentChanged()
         // If you couldn't find your parent, we put you into OrphanChildren set and every time we spawn another NetworkObject locally due to replication,
         // we call CheckOrphanChildren() method and quickly iterate over OrphanChildren set and see if we can reparent/adopt one.
         internal static HashSet<NetworkObject> OrphanChildren = new HashSet<NetworkObject>();
+#if UNITY_EDITOR
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
+        private static void ResetStaticsOnLoad() => OrphanChildren = new HashSet<NetworkObject>();
+#endif
 
         internal bool ApplyNetworkParenting(bool removeParent = false, bool ignoreNotSpawned = false, bool orphanedChildPass = false, bool enableNotification = true)
         {

com.unity.netcode.gameobjects/Runtime/Core/NetworkUpdateLoop.cs

@@ -291,6 +291,16 @@ public static PlayerLoopSystem CreateLoopSystem()
         [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
         private static void Initialize()
         {
+#if UNITY_EDITOR
+            s_UpdateSystem_Sets = new Dictionary<NetworkUpdateStage, HashSet<INetworkUpdateSystem>>();
+            s_UpdateSystem_Arrays = new Dictionary<NetworkUpdateStage, INetworkUpdateSystem[]>();
+            foreach (NetworkUpdateStage updateStage in Enum.GetValues(typeof(NetworkUpdateStage)))
+            {
+                s_UpdateSystem_Sets.Add(updateStage, new HashSet<INetworkUpdateSystem>());
+                s_UpdateSystem_Arrays.Add(updateStage, new INetworkUpdateSystem[k_UpdateSystem_InitialArrayCapacity]);
+            }
+            UpdateStage = default;
+#endif
             UnregisterLoopSystems();
             RegisterLoopSystems();
         }