Update all tests that override OnNewClientCreated

Author: EmandM

com.unity.netcode.gameobjects/Tests/Runtime/NetworkBehaviourPrePostSpawnTests.cs

@@ -88,12 +88,6 @@ protected override IEnumerator OnSetup()
             return base.OnSetup();
         }
 
-        protected override void OnNewClientCreated(NetworkManager networkManager)
-        {
-            networkManager.NetworkConfig.Prefabs = m_ServerNetworkManager.NetworkConfig.Prefabs;
-            base.OnNewClientCreated(networkManager);
-        }
-
         /// <summary>
         /// This validates that pre spawn can be used to instantiate and assign a NetworkVariable (or other prespawn tasks)
         /// which can be useful for assigning a NetworkVariable value on the server side when the NetworkVariable has owner write permissions.

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformBase.cs

@@ -339,7 +339,6 @@ protected override IEnumerator OnServerAndClientsConnected()
         /// </summary>
         protected override void OnNewClientCreated(NetworkManager networkManager)
         {
-            networkManager.NetworkConfig.Prefabs = m_ServerNetworkManager.NetworkConfig.Prefabs;
             networkManager.NetworkConfig.TickRate = GetTickRate();
             if (m_EnableVerboseDebug)
             {

testproject/Assets/Tests/Runtime/Animation/NetworkAnimatorTests.cs

@@ -626,19 +626,6 @@ public IEnumerator TriggerUpdateTests([Values] OwnerShipMode ownerShipMode, [Val
             VerboseDebug($" ------------------ Trigger Test [{TriggerTest.Iteration}][{ownerShipMode}] Stopping ------------------ ");
         }
 
-        protected override void OnNewClientCreated(NetworkManager networkManager)
-        {
-            var networkPrefab = new NetworkPrefab() { Prefab = m_AnimationTestPrefab };
-            networkManager.NetworkConfig.Prefabs.Add(networkPrefab);
-            networkPrefab = new NetworkPrefab() { Prefab = m_AnimationOwnerTestPrefab };
-            networkManager.NetworkConfig.Prefabs.Add(networkPrefab);
-
-            networkPrefab = new NetworkPrefab() { Prefab = m_AnimationCheerTestPrefab };
-            networkManager.NetworkConfig.Prefabs.Add(networkPrefab);
-            networkPrefab = new NetworkPrefab() { Prefab = m_AnimationCheerOwnerTestPrefab };
-            networkManager.NetworkConfig.Prefabs.Add(networkPrefab);
-        }
-
         /// <summary>
         /// Verifies that triggers are synchronized with currently connected clients
         /// </summary>

testproject/Assets/Tests/Runtime/DontDestroyOnLoadTests.cs

@@ -22,12 +22,6 @@ protected override void OnServerAndClientsCreated()
             base.OnServerAndClientsCreated();
         }
 
-        protected override void OnNewClientCreated(NetworkManager networkManager)
-        {
-            networkManager.NetworkConfig.Prefabs = m_ServerNetworkManager.NetworkConfig.Prefabs;
-            base.OnNewClientCreated(networkManager);
-        }
-
         private ulong m_SpawnedNetworkObjectId;
         private StringBuilder m_ErrorLog = new StringBuilder();
 

testproject/Assets/Tests/Runtime/PrefabExtendedTests.cs

@@ -129,11 +129,10 @@ protected override void OnNewClientCreated(NetworkManager networkManager)
         {
             networkManager.NetworkConfig.EnableSceneManagement = m_SceneManagementEnabled;
             networkManager.NetworkConfig.Prefabs.NetworkPrefabsLists.Add(PrefabTestConfig.Instance.TestPrefabs);
-            base.OnNewClientCreated(networkManager);
         }
 
         /// <summary>
-        /// Validates that all spawned NetworkObjects are present and their corresponding 
+        /// Validates that all spawned NetworkObjects are present and their corresponding
         /// GlobalObjectIdHash values match
         /// </summary>
         private bool ValidateAllClientsSpawnedObjects()
@@ -227,7 +226,7 @@ public IEnumerator TestPrefabsSpawning([Values] InstantiateAndSpawnMethods insta
             yield return CreateAndStartNewClient();
 
             var spawnManager = m_ServerNetworkManager.SpawnManager;
-            // If scene management is enabled, then we want to verify against the editor 
+            // If scene management is enabled, then we want to verify against the editor
             // assigned in-scene placed NetworkObjects
             if (m_SceneManagementEnabled)
             {
@@ -303,7 +302,7 @@ public IEnumerator TestPrefabsSpawning([Values] InstantiateAndSpawnMethods insta
         [UnityTest]
         public IEnumerator TestsInstantiateAndSpawnErrors([Values] InstantiateAndSpawnMethods instantiateAndSpawnType)
         {
-            // If scene management is enabled, then we want to verify against the editor 
+            // If scene management is enabled, then we want to verify against the editor
             // assigned in-scene placed NetworkObjects
             if (m_SceneManagementEnabled)
             {
@@ -344,7 +343,7 @@ public IEnumerator TestsInstantiateAndSpawnErrors([Values] InstantiateAndSpawnMe
             m_ServerNetworkManager.Shutdown();
             LogAssert.Expect(LogType.Warning, NetworkSpawnManager.InstantiateAndSpawnErrors[NetworkSpawnManager.InstantiateAndSpawnErrorTypes.InvokedWhenShuttingDown]);
             InstantiateAndSpawn(m_ObjectsToSpawn[0], instantiateAndSpawnType);
-            // The not listening error can only happen when trying to instantiate and spawn on a Network Prefab 
+            // The not listening error can only happen when trying to instantiate and spawn on a Network Prefab
             if (instantiateAndSpawnType == InstantiateAndSpawnMethods.NetworkObject)
             {
                 LogAssert.Expect(LogType.Error, NetworkSpawnManager.InstantiateAndSpawnErrors[NetworkSpawnManager.InstantiateAndSpawnErrorTypes.NoActiveSession]);