fix: UnifiedBootstrap creates a duplicate LocalWorld on 7000.0.0a12+ (#4243)

* fix: UnifiedBootstrap no longer creates a duplicate LocalWorld on 7000.0.0a12+

From 7000.0.0a12 Entities creates the default world and all of its systems
before it calls the custom bootstrap. UnifiedBootstrap still called
CreateLocalWorld("LocalWorld") when no NetworkManager was initializing, so a
second world ran every default system. Systems that hand state to
NetworkManager (for example a system that registers itself with the transform
state manager) could end up bound to the empty LocalWorld instead of the world
that holds the scene's entities.

Under UNITY_ENTITIES_WORLD_LIFETIME_CHANGES (the same version define N4E uses)
the bootstrap now uses the existing default world.

* Update CHANGELOG

* update

Bumping NGO version.
Updating validation exceptions file with the bumped version.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -18,6 +18,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 
 ### Fixed
 
+- Issue where the unified bootstrap created a second world that ran a duplicate of every default system next to the default world. (#4243)
 - Ensured a useful and human readable error is logged when a NetworkVariable is trying to serialize a private or protected type. (#4239)
 - Issue where `NetworkAnimator` logged an error for a trigger-conditioned transition into an Exit node, and a client that joined during that transition, or during one into a sub-state machine, did not synchronize with it. Transitions that pass through Exit, Entry or sub-state machine nodes now resolve to the state they reach, and a late-joining client cross-fades from the matching originating state when several states transition into the same destination. (#4238)
 - Ensured all callbacks are wrapped with exception handling to avoid silent errors. (#4161)

com.unity.netcode.gameobjects/Runtime/Components/Helpers/UnifiedBootstrap.cs

@@ -112,7 +112,13 @@ public override bool Initialize(string defaultWorldName)
             }
             else
             {
+#if UNITY_ENTITIES_WORLD_LIFETIME_CHANGES
+                // Entities creates the default world and all its systems before calling the bootstrap, so a local world
+                // here would run a second copy of every system against a world that holds none of the scene's entities.
+                LastCreatedWorld = World.DefaultGameObjectInjectionWorld;
+#else
                 LastCreatedWorld = CreateLocalWorld("LocalWorld");
+#endif
             }
 
             // Always wrap events that can invoke user script in a try-catch to assure any

com.unity.netcode.gameobjects/Runtime/Unity.Netcode.Runtime.asmdef

@@ -101,6 +101,11 @@
             "expression": "0.1.0",
             "define": "UNITY_MULTIPLAYER_PLAYMODE"
         },
+        {
+            "name": "Unity",
+            "expression": "7000.0.0a12",
+            "define": "UNITY_ENTITIES_WORLD_LIFETIME_CHANGES"
+        },
         {
             "name": "Unity",
             "expression": "[6000.4.0b5,6000.5.0a1)",

com.unity.netcode.gameobjects/ValidationExceptions.json

@@ -3,12 +3,12 @@
     {
       "ValidationTest": "NDA Keyword Validation",
       "ExceptionMessage": "#if UNITY_7000_0_OR_NEWER",
-      "PackageVersion": "3.2.1"
+      "PackageVersion": "3.2.2"
     },
     {
       "ValidationTest": "NDA Keyword Validation",
       "ExceptionMessage": "File 'Editor/InScenePlacedProcessor.cs' contains deny-listed keyword pattern '(?<!BestPracticeUnderstandingPerformanceIn)unity[ _]*7' It must not be published",
-      "PackageVersion": "3.2.1"
+      "PackageVersion": "3.2.2"
     }
   ],
   "WarningExceptions": []

com.unity.netcode.gameobjects/package.json

@@ -2,7 +2,7 @@
   "name": "com.unity.netcode.gameobjects",
   "displayName": "Netcode for GameObjects",
   "description": "Netcode for GameObjects is a high-level netcode SDK that provides networking capabilities to GameObject/MonoBehaviour workflows within Unity and sits on top of underlying transport layer.",
-  "version": "3.2.1",
+  "version": "3.2.2",
   "unity": "6000.7",
   "unityRelease": "0b8",
   "dependencies": {