Skip to content

Commit fb824ac

Browse files
committed
feat: add rel & title attrs to links
1 parent a7c1442 commit fb824ac

4 files changed

Lines changed: 60 additions & 10 deletions

File tree

src/components/header/repo-form.vue

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,24 @@
1010
<ol v-if="!form.integrations.uptimerobotKey">
1111
<li>
1212
Go to
13-
<a href="https://uptimerobot.com/dashboard.php#mySettings" target="_blank">
13+
<a
14+
href="https://uptimerobot.com/dashboard.php#mySettings"
15+
target="_blank"
16+
rel="noopener noreferrer"
17+
title="Go to UptimeRobot settings"
18+
>
1419
Settings
1520
</a>
1621
</li>
1722
<li>Find "Monitor-Specific API Keys"</li>
1823
<li>Find your monitor</li>
1924
<li>Copy and paste it's API key here</li>
2025
</ol>
21-
<input v-model.trim="form.integrations.uptimerobotKey" name="uptimerobotKey" placeholder="uptimerobot monitor key">
26+
<input
27+
v-model.trim="form.integrations.uptimerobotKey"
28+
name="uptimerobotKey"
29+
placeholder="uptimerobot monitor key"
30+
>
2231
</fieldset>
2332
<fieldset v-if="form.name">
2433
<legend>Netlify Deploy Status</legend>
@@ -28,6 +37,8 @@
2837
<a
2938
:href="`https://app.netlify.com/sites/${form.name}/configuration/general#site-information`"
3039
target="_blank"
40+
rel="noopener noreferrer"
41+
title="Go to Netlify site details"
3142
>
3243
Site Details
3344
</a>

src/components/modals/about-modal.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@
5858
<h2>Contact</h2>
5959
<p>
6060
For any questions or concerns, please reach out to the developer at the app's
61-
<a href="https://github.com/VChet/github-metrics">GitHub repository</a>
61+
<a href="https://github.com/VChet/github-metrics" rel="noopener noreferrer" title="Go to GitHub repository">
62+
GitHub repository
63+
</a>
6264
</p>
6365
</div>
6466
</dialog>

src/components/repo-item.vue

Lines changed: 31 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,13 @@
66
<icon-template v-if="repo.is_template" />
77
<icon-lock v-if="repo.private" />
88
<icon-archive v-if="repo.archived" />
9-
<a v-dompurify-html="repoName" :href="repo.html_url" class="text-truncate icon-button" />
9+
<a
10+
v-dompurify-html="repoName"
11+
:href="repo.html_url"
12+
rel="noopener noreferrer"
13+
:title="`Go to ${repo.full_name} repository`"
14+
class="text-truncate icon-button"
15+
/>
1016
</h2>
1117
<div class="repo__header-actions">
1218
<edit-repo :repo />
@@ -41,7 +47,12 @@
4147
{{ repo.integrations.analytics }}
4248
</li>
4349
<li v-if="repo.homepage">
44-
<a :href="repo.homepage">
50+
<a
51+
:href="repo.homepage"
52+
target="_blank"
53+
rel="noopener noreferrer"
54+
title="Go to website"
55+
>
4556
<icon-external-link />
4657
{{ hostingName ?? "Website" }}
4758
</a>
@@ -54,19 +65,34 @@
5465
{{ repo.language }}
5566
</span>
5667
<!-- Stars -->
57-
<a :href="`https://github.com/${repo.full_name}/stargazers`" title="stars">
68+
<a
69+
:href="`https://github.com/${repo.full_name}/stargazers`"
70+
target="_blank"
71+
rel="noopener noreferrer"
72+
title="Go to stargazers"
73+
>
5874
<icon-star />
5975
{{ repo.stargazers_count }}
6076
<metric-delta :delta="repoDiff?.stars" />
6177
</a>
6278
<!-- Forks -->
63-
<a :href="`https://github.com/${repo.full_name}/forks`" title="forks">
79+
<a
80+
:href="`https://github.com/${repo.full_name}/forks`"
81+
target="_blank"
82+
rel="noopener noreferrer"
83+
title="Go to forks"
84+
>
6485
<icon-git-fork />
6586
{{ repo.forks_count }}
6687
<metric-delta :delta="repoDiff?.forks" />
6788
</a>
6889
<!-- Issues -->
69-
<a :href="`https://github.com/${repo.full_name}/issues?q=is%3Aopen`" title="open issues/prs">
90+
<a
91+
:href="`https://github.com/${repo.full_name}/issues?q=is%3Aopen`"
92+
target="_blank"
93+
rel="noopener noreferrer"
94+
title="Go to open issues/prs"
95+
>
7096
<icon-circle-dot />
7197
{{ repo.open_issues_count }}
7298
<metric-delta :delta="repoDiff?.issues" inverse />

src/pages/dependencies.vue

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@
2020
<tr>
2121
<th />
2222
<th v-for="repo in repos" :key="repo.id">
23-
<a :href="repo.html_url" target="_blank">
23+
<a
24+
:href="repo.html_url"
25+
target="_blank"
26+
rel="noopener noreferrer"
27+
:title="`Go to ${repo.full_name} repository`"
28+
>
2429
{{ settings.displayOwner ? repo.full_name : repo.name }}
2530
</a>
2631
</th>
@@ -32,7 +37,13 @@
3237
<button class="icon" type="button" title="exclude dependency" @click="hideDependency(dep)">
3338
<icon-x />
3439
</button>
35-
<a :href="`https://npmjs.org/${dep}`" target="_blank" class="text-truncate">
40+
<a
41+
:href="`https://npmjs.org/${dep}`"
42+
target="_blank"
43+
rel="noopener noreferrer"
44+
:title="`Go to ${dep} on npm`"
45+
class="text-truncate"
46+
>
3647
{{ dep }}
3748
<div>{{ latestVersions[dep] ?? '???' }}</div>
3849
</a>

0 commit comments

Comments
 (0)