Merge pull request #11 from VectifyAI/bugfix/compiler-update-fixes

fix: compiler concept update bugs

Author: rejojer

openkb/agent/compiler.py

@@ -284,6 +284,57 @@ def _read_concept_briefs(wiki_dir: Path) -> str:
     return "\n".join(lines) or "(none yet)"
 
 
+def _get_section_bounds(lines: list[str], heading: str) -> tuple[int, int] | None:
+    """Return the [start, end) bounds for a Markdown H2 section."""
+    for i, line in enumerate(lines):
+        if line == heading:
+            start = i + 1
+            end = len(lines)
+            for j in range(start, len(lines)):
+                if lines[j].startswith("## "):
+                    end = j
+                    break
+            return start, end
+    return None
+
+
+def _section_contains_link(lines: list[str], heading: str, link: str) -> bool:
+    """Check whether an index entry already exists inside the named section."""
+    bounds = _get_section_bounds(lines, heading)
+    if bounds is None:
+        return False
+
+    start, end = bounds
+    entry_prefix = f"- {link}"
+    return any(line.startswith(entry_prefix) for line in lines[start:end])
+
+
+def _replace_section_entry(lines: list[str], heading: str, link: str, entry: str) -> bool:
+    """Replace the first matching entry within a specific section."""
+    bounds = _get_section_bounds(lines, heading)
+    if bounds is None:
+        return False
+
+    start, end = bounds
+    entry_prefix = f"- {link}"
+    for i in range(start, end):
+        if lines[i].startswith(entry_prefix):
+            lines[i] = entry
+            return True
+    return False
+
+
+def _insert_section_entry(lines: list[str], heading: str, entry: str) -> bool:
+    """Insert a new entry at the top of a specific section."""
+    bounds = _get_section_bounds(lines, heading)
+    if bounds is None:
+        return False
+
+    start, _ = bounds
+    lines.insert(start, entry)
+    return True
+
+
 
 def _write_summary(wiki_dir: Path, doc_name: str, summary: str,
                     doc_type: str = "short") -> None:
@@ -460,7 +511,6 @@ def _backlink_concepts(wiki_dir: Path, doc_name: str, concept_slugs: list[str])
             text += f"\n\n## Related Documents\n- {link}\n"
         path.write_text(text, encoding="utf-8")
 
-
 def _update_index(
     wiki_dir: Path, doc_name: str, concept_names: list[str],
     doc_brief: str = "", concept_briefs: dict[str, str] | None = None,
@@ -469,8 +519,9 @@ def _update_index(
     """Append document and concept entries to index.md.
 
     When ``doc_brief`` or entries in ``concept_briefs`` are provided, entries
-    are written as ``- [[link]] (type) — brief text``.  Existing entries are
-    detected by the link part only and skipped to avoid duplicates.
+    are written as ``- [[link]] (type) — brief text``. Existing entries are
+    detected within their own section by exact entry prefix and skipped to
+    avoid duplicates.
     ``doc_type`` is ``"short"`` or ``"pageindex"`` — shown in the entry so the
     query agent knows how to access detailed content.
     """
@@ -484,34 +535,27 @@ def _update_index(
             encoding="utf-8",
         )
 
-    text = index_path.read_text(encoding="utf-8")
+    lines = index_path.read_text(encoding="utf-8").split("\n")
 
     doc_link = f"[[summaries/{doc_name}]]"
-    if doc_link not in text:
+    if not _section_contains_link(lines, "## Documents", doc_link):
         doc_entry = f"- {doc_link} ({doc_type})"
         if doc_brief:
             doc_entry += f" — {doc_brief}"
-        if "## Documents" in text:
-            text = text.replace("## Documents\n", f"## Documents\n{doc_entry}\n", 1)
+        _insert_section_entry(lines, "## Documents", doc_entry)
 
     for name in concept_names:
         concept_link = f"[[concepts/{name}]]"
         concept_entry = f"- {concept_link}"
         if name in concept_briefs:
             concept_entry += f" — {concept_briefs[name]}"
-        if concept_link in text:
+        if _section_contains_link(lines, "## Concepts", concept_link):
             if name in concept_briefs:
-                lines = text.split("\n")
-                for i, line in enumerate(lines):
-                    if concept_link in line:
-                        lines[i] = concept_entry
-                        break
-                text = "\n".join(lines)
+                _replace_section_entry(lines, "## Concepts", concept_link, concept_entry)
         else:
-            if "## Concepts" in text:
-                text = text.replace("## Concepts\n", f"## Concepts\n{concept_entry}\n", 1)
+            _insert_section_entry(lines, "## Concepts", concept_entry)
 
-    index_path.write_text(text, encoding="utf-8")
+    index_path.write_text("\n".join(lines), encoding="utf-8")
 
 
 # ---------------------------------------------------------------------------

tests/test_compiler.py

@@ -198,6 +198,26 @@ def test_appends_entries_with_briefs(self, tmp_path):
         assert "[[concepts/attention]] — Focus mechanism" in text
         assert "[[concepts/transformer]] — NN architecture" in text
 
+    def test_updates_only_exact_concept_row(self, tmp_path):
+        wiki = tmp_path / "wiki"
+        wiki.mkdir()
+        (wiki / "index.md").write_text(
+            "# Index\n\n## Documents\n\n## Concepts\n"
+            "- [[concepts/transformer]] — Uses [[concepts/attention]] internally\n"
+            "- [[concepts/attention]] — Old brief\n\n## Explorations\n",
+            encoding="utf-8",
+        )
+        _update_index(
+            wiki,
+            "my-doc",
+            ["attention"],
+            concept_briefs={"attention": "New brief"},
+        )
+        text = (wiki / "index.md").read_text()
+        assert "- [[concepts/transformer]] — Uses [[concepts/attention]] internally" in text
+        assert "- [[concepts/attention]] — New brief" in text
+        assert text.count("[[concepts/attention]] — New brief") == 1
+
     def test_no_duplicates(self, tmp_path):
         wiki = tmp_path / "wiki"
         wiki.mkdir()
@@ -221,6 +241,54 @@ def test_backwards_compat_no_briefs(self, tmp_path):
         assert "[[summaries/my-doc]]" in text
         assert "[[concepts/attention]]" in text
 
+    def test_updates_concept_brief_only_inside_concepts_section(self, tmp_path):
+        wiki = tmp_path / "wiki"
+        wiki.mkdir()
+        (wiki / "index.md").write_text(
+            "# Index\n\n"
+            "## Documents\n"
+            "- [[summaries/my-doc]] (short) — Mentions [[concepts/attention]] here\n\n"
+            "## Concepts\n"
+            "- [[concepts/attention]] — Old brief\n\n"
+            "## Explorations\n",
+            encoding="utf-8",
+        )
+
+        _update_index(
+            wiki,
+            "my-doc",
+            ["attention"],
+            concept_briefs={"attention": "New brief"},
+        )
+
+        text = (wiki / "index.md").read_text()
+        assert "- [[summaries/my-doc]] (short) — Mentions [[concepts/attention]] here" in text
+        assert "- [[concepts/attention]] — New brief" in text
+        assert "- [[concepts/attention]] — Old brief" not in text
+
+    def test_adds_concept_entry_when_link_exists_outside_concepts_section(self, tmp_path):
+        wiki = tmp_path / "wiki"
+        wiki.mkdir()
+        (wiki / "index.md").write_text(
+            "# Index\n\n"
+            "## Documents\n"
+            "- [[summaries/my-doc]] (short) — Mentions [[concepts/attention]] here\n\n"
+            "## Concepts\n\n"
+            "## Explorations\n",
+            encoding="utf-8",
+        )
+
+        _update_index(
+            wiki,
+            "my-doc",
+            ["attention"],
+            concept_briefs={"attention": "New brief"},
+        )
+
+        text = (wiki / "index.md").read_text()
+        assert "- [[summaries/my-doc]] (short) — Mentions [[concepts/attention]] here" in text
+        assert "- [[concepts/attention]] — New brief" in text
+
 
 class TestReadWikiContext:
     def test_empty_wiki(self, tmp_path):