Fix exact concept index row matching

Author: rejojer

openkb/agent/compiler.py

@@ -461,6 +461,35 @@ def _backlink_concepts(wiki_dir: Path, doc_name: str, concept_slugs: list[str])
         path.write_text(text, encoding="utf-8")
 
 
+def _find_section_bounds(lines: list[str], heading: str) -> tuple[int, int] | None:
+    """Return [start, end) line indexes for a section headed by ``heading``."""
+    for i, line in enumerate(lines):
+        if line != heading:
+            continue
+        start = i + 1
+        end = len(lines)
+        for j in range(start, len(lines)):
+            if lines[j].startswith("## "):
+                end = j
+                break
+        return start, end
+    return None
+
+
+def _find_index_entry_line(lines: list[str], heading: str, link: str) -> int | None:
+    """Find an index entry that starts with ``- {link}`` inside one section only."""
+    bounds = _find_section_bounds(lines, heading)
+    if bounds is None:
+        return None
+
+    start, end = bounds
+    entry_prefix = f"- {link}"
+    for i in range(start, end):
+        if lines[i].startswith(entry_prefix):
+            return i
+    return None
+
+
 def _update_index(
     wiki_dir: Path, doc_name: str, concept_names: list[str],
     doc_brief: str = "", concept_briefs: dict[str, str] | None = None,
@@ -484,34 +513,32 @@ def _update_index(
             encoding="utf-8",
         )
 
-    text = index_path.read_text(encoding="utf-8")
+    lines = index_path.read_text(encoding="utf-8").split("\n")
 
     doc_link = f"[[summaries/{doc_name}]]"
-    if doc_link not in text:
+    if _find_index_entry_line(lines, "## Documents", doc_link) is None:
         doc_entry = f"- {doc_link} ({doc_type})"
         if doc_brief:
             doc_entry += f" — {doc_brief}"
-        if "## Documents" in text:
-            text = text.replace("## Documents\n", f"## Documents\n{doc_entry}\n", 1)
+        doc_bounds = _find_section_bounds(lines, "## Documents")
+        if doc_bounds is not None:
+            lines.insert(doc_bounds[0], doc_entry)
 
     for name in concept_names:
         concept_link = f"[[concepts/{name}]]"
         concept_entry = f"- {concept_link}"
         if name in concept_briefs:
             concept_entry += f" — {concept_briefs[name]}"
-        if concept_link in text:
+        concept_line = _find_index_entry_line(lines, "## Concepts", concept_link)
+        if concept_line is not None:
             if name in concept_briefs:
-                lines = text.split("\n")
-                for i, line in enumerate(lines):
-                    if concept_link in line:
-                        lines[i] = concept_entry
-                        break
-                text = "\n".join(lines)
+                lines[concept_line] = concept_entry
         else:
-            if "## Concepts" in text:
-                text = text.replace("## Concepts\n", f"## Concepts\n{concept_entry}\n", 1)
+            concept_bounds = _find_section_bounds(lines, "## Concepts")
+            if concept_bounds is not None:
+                lines.insert(concept_bounds[0], concept_entry)
 
-    index_path.write_text(text, encoding="utf-8")
+    index_path.write_text("\n".join(lines), encoding="utf-8")
 
 
 # ---------------------------------------------------------------------------

tests/test_compiler.py

@@ -198,6 +198,26 @@ def test_appends_entries_with_briefs(self, tmp_path):
         assert "[[concepts/attention]] — Focus mechanism" in text
         assert "[[concepts/transformer]] — NN architecture" in text
 
+    def test_updates_only_exact_concept_row(self, tmp_path):
+        wiki = tmp_path / "wiki"
+        wiki.mkdir()
+        (wiki / "index.md").write_text(
+            "# Index\n\n## Documents\n\n## Concepts\n"
+            "- [[concepts/transformer]] — Uses [[concepts/attention]] internally\n"
+            "- [[concepts/attention]] — Old brief\n\n## Explorations\n",
+            encoding="utf-8",
+        )
+        _update_index(
+            wiki,
+            "my-doc",
+            ["attention"],
+            concept_briefs={"attention": "New brief"},
+        )
+        text = (wiki / "index.md").read_text()
+        assert "- [[concepts/transformer]] — Uses [[concepts/attention]] internally" in text
+        assert "- [[concepts/attention]] — New brief" in text
+        assert text.count("[[concepts/attention]] — New brief") == 1
+
     def test_no_duplicates(self, tmp_path):
         wiki = tmp_path / "wiki"
         wiki.mkdir()