Skip to content

Commit 86e05d6

Browse files
committed
[OPTIONS] Adapt to the new way of passing process launcher options.
1 parent 2f425ac commit 86e05d6

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

Launcher.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ SERVICE_REGISTRATION(Launcher, 1, 0);
6161

6262
_deactivationInProgress = true;
6363

64-
_memory->Observe(0);
65-
6664
_activity->Shutdown();
6765
_observer.Unregister(&_notification);
6866
_activity.Release();

Launcher.h

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -566,10 +566,11 @@ class Launcher : public PluginHost::IPlugin {
566566

567567
if ((element.Option.IsSet() == true) && (element.Option.Value().empty() == false)) {
568568
if ((element.Value.IsSet() == true) && (element.Value.Value().empty() == false)) {
569-
_options.Set(element.Option.Value(), element.Value.Value());
569+
_options.Add(element.Option.Value());
570+
_options.Add(element.Value.Value());
570571
}
571572
else {
572-
_options.Set(element.Option.Value());
573+
_options.Add(element.Option.Value());
573574
}
574575
}
575576
}
@@ -618,13 +619,6 @@ class Launcher : public PluginHost::IPlugin {
618619
ProcessList::iterator position (std::find(_processList.begin(), _processList.end(), info.Id()));
619620
if (position != _processList.end()) {
620621
_processList.erase(position);
621-
if ( (info.Id() ==_processList.front()) && (_process.IsActive() == false) ) {
622-
_memory->Observe(0);
623-
}
624-
else {
625-
// TODO: Probably might need to add the read exit code here for any process that exits to prevent
626-
// Zombie processes here..
627-
}
628622
if (_processList.size() == 0) {
629623
_processListEmpty.Unlock();
630624
}
@@ -703,7 +697,6 @@ class Launcher : public PluginHost::IPlugin {
703697
TRACE(Trace::Information, (_T("Launched command: %s [%d]."), _options.Command().c_str(), Pid()));
704698
ASSERT (_memory != nullptr);
705699

706-
_memory->Observe(Pid());
707700
_shutdownCompleted.Unlock();
708701
}
709702

0 commit comments

Comments
 (0)