Minor corrections as per code review comments

Author: HaseenaSainul

Launcher.cpp

@@ -7,7 +7,7 @@ ENUM_CONVERSION_BEGIN(Plugin::Launcher::mode)
 
     { Plugin::Launcher::mode::RELATIVE, _TXT("relative") },
     { Plugin::Launcher::mode::ABSOLUTE, _TXT("absolute") },
-    { Plugin::Launcher::mode::ABSOLUTE_WITH_INTERVAL, _TXT("absolute_with_interval") },
+    { Plugin::Launcher::mode::ABSOLUTE_WITH_INTERVAL, _TXT("interval") },
 
     ENUM_CONVERSION_END(Plugin::Launcher::mode)
 ;
@@ -219,21 +219,23 @@ Core::Time Launcher::FindAbsoluteTimeForSchedule(const Time& absoluteTime, const
         }
     }
     else {
-        if (slotTime >= startTime) {
-            uint32_t jump (absoluteTime.HasHours() ? HoursPerDay * MinutesPerHour * SecondsPerMinute : (absoluteTime.HasMinutes() ? MinutesPerHour * SecondsPerMinute : SecondsPerMinute));
-
-            // Go back the biggest chunk of the absoluteTime
-            slotTime.Sub(jump * 100);
-        }
         uint32_t intervalJump = ( (interval.HasHours()   ? interval.Hours() * MinutesPerHour * SecondsPerMinute : 0) +
                                   (interval.HasMinutes() ? interval.Minutes() * SecondsPerMinute : 0) +
                                    interval.Seconds() ) * 100;
 
         ASSERT (intervalJump != 0);
+        if (slotTime >= startTime) {
+            Core::Time workTime (slotTime);
 
-        // Now increment with the intervall till we reach a valid point
-        while (slotTime < startTime) {
-            slotTime.Add(intervalJump);
+            while (workTime.Sub(intervalJump) > startTime) {
+                slotTime.Sub(intervalJump);
+            }
+        }
+        else {
+            // Now increment with the intervall till we reach a valid point
+            while (slotTime < startTime) {
+                slotTime.Add(intervalJump);
+            }
         }
     }
 

README.md

@@ -69,14 +69,14 @@ Plugin to "Launch" linux applications and scripts
        { "option": "-h"}
       ],
      "schedule": {
-       "mode": 0,
+       "mode": "relative",
        "time": "06:04.10"
      }
    }
    ```
 
 Note:
-1. If field "mode" is zero or not set, it will treat the time as relative
+1. If field "mode" is empty or not set, it will treat the time as relative
 2. If relative time value is "00:00.00"/invalid format/not set, the launcher will ignore the given time and launch the application at the launcher activation time itself.
 3. If time format given is
   a. "XX", treat it as SS
@@ -93,7 +93,7 @@ Note:
        { "option": "-h"}
       ],
      "schedule": {
-       "mode": 1,
+       "mode": "absolute",
        "time": "06:04.10"
      }
    }
@@ -121,7 +121,7 @@ Note:
        { "option": "-h"}
       ],
       "schedule": {
-        "mode": 2,
+        "mode": "interval",
         "time": "06:04.10",
         "interval": "00:40.10"
       }
@@ -130,9 +130,9 @@ Note:
 
 Note:
 1. If interval value is "00:00.00"/invalid format/not set, the launcher will treat it as invalid value and ignore the interval time settings.
-2. If mode is 2 (absolute with interval) and interval is set, it will identify next matching time and schedule application launch to that time.
+2. If mode is interval (absolute with interval) and interval is set, it will identify next matching time and schedule application launch to that time.
    i.e, if the absolute time given is 04:00:00, current time is 05:10:00 and interval is 00:30:00, then next scheduling time will be 05:30:00 (will be identified from the next intervals - 04:30:00, 05:00:00, 05:30:00)
-3. If mode is 0(relative) or 1(absolute), the interval time will be taken only for the subsequent scheduling
+3. If mode is relative or absolute, the interval time will be taken only for the subsequent scheduling
 
 # How to launch multiple scripts/applcations