Merge pull request #1376 from asurdej-comcast/key_throttle

[KeyEvent] Throttle keys repetition

Author: magomez

Source/WebKit/Shared/WebKeyboardEvent.cpp

@@ -223,4 +223,18 @@ bool WebKeyboardEvent::isKeyboardEventType(Type type)
     return type == RawKeyDown || type == KeyDown || type == KeyUp || type == Char;
 }
 
+bool operator==(const WebKeyboardEvent& a, const WebKeyboardEvent& b)
+{
+    return a.type() == b.type()
+        && a.modifiers() == b.modifiers()
+        && a.text() == b.text()
+        && a.unmodifiedText() == b.unmodifiedText()
+        && a.key() == b.key()
+        && a.code() == b.code()
+        && a.keyIdentifier() == b.keyIdentifier()
+        && a.windowsVirtualKeyCode() == b.windowsVirtualKeyCode()
+        && a.nativeVirtualKeyCode() == b.nativeVirtualKeyCode()
+        && a.macCharCode() == b.macCharCode();
+}
+
 } // namespace WebKit

Source/WebKit/Shared/WebKeyboardEvent.h

@@ -82,6 +82,7 @@ class WebKeyboardEvent : public WebEvent {
 
     static bool isKeyboardEventType(Type);
 
+    friend bool operator==(const WebKeyboardEvent&, const WebKeyboardEvent&);
 private:
     String m_text;
     String m_unmodifiedText;

Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -3111,6 +3111,11 @@ bool WebPageProxy::handleKeyboardEvent(const NativeWebKeyboardEvent& event)
 
     LOG(KeyHandling, "WebPageProxy::handleKeyboardEvent: %s", webKeyboardEventTypeString(event.type()));
 
+    if (event.type() == WebEvent::KeyDown && !m_keyEventQueue.isEmpty() && m_keyEventQueue.last() == event) {
+        // Throtthe key repetition if we still have previous keypress pending
+        return true;
+    }
+
     m_keyEventQueue.append(event);
 
     m_process->startResponsivenessTimer(event.type() == WebEvent::KeyDown ? WebProcessProxy::UseLazyStop::Yes : WebProcessProxy::UseLazyStop::No);