Quirks: Add fakevideosink hole-punch quirk

Author: philn

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -4036,7 +4036,7 @@ class GStreamerHolePunchClient : public TextureMapperPlatformLayerBuffer::HolePu
 bool MediaPlayerPrivateGStreamer::isHolePunchRenderingEnabled() const
 {
     auto& quirksManager = GStreamerQuirksManager::singleton();
-    return quirksManager.isEnabled() && quirksManager.supportsVideoHolePunchRendering();
+    return quirksManager.supportsVideoHolePunchRendering();
 }
 
 GstElement* MediaPlayerPrivateGStreamer::createHolePunchVideoSink()

Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkFake.h

@@ -0,0 +1,39 @@
+/*
+ * Copyright (C) 2024 Igalia S.L
+ * Copyright (C) 2024 Metrological Group B.V.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public License
+ * aint with this library; see the file COPYING.LIB.  If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#pragma once
+
+#if USE(GSTREAMER)
+
+#include "GStreamerCommon.h"
+#include "GStreamerQuirks.h"
+
+namespace WebCore {
+
+class GStreamerHolePunchQuirkFake final : public GStreamerHolePunchQuirk {
+public:
+    const char* identifier() final { return "FakeHolePunch"; }
+    GstElement* createHolePunchVideoSink(bool, const MediaPlayer*) final { return makeGStreamerElement("fakevideosink", nullptr); }
+    bool setHolePunchVideoRectangle(GstElement*, const IntRect&) final { return true; }
+};
+
+} // namespace WebCore
+
+#endif // USE(GSTREAMER)

Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp

@@ -25,6 +25,7 @@
 
 #include "GStreamerCommon.h"
 #include "GStreamerHolePunchQuirkBcmNexus.h"
+#include "GStreamerHolePunchQuirkFake.h"
 #include "GStreamerHolePunchQuirkWesteros.h"
 #include "GStreamerQuirkAmLogic.h"
 #include "GStreamerQuirkBcmNexus.h"
@@ -126,7 +127,7 @@ GStreamerQuirksManager::GStreamerQuirksManager()
         return;
 
     if (WTF::equalLettersIgnoringASCIICase(holePunchQuirk, "help"_s)) {
-        WTFLogAlways("Supported quirks for WEBKIT_GST_HOLE_PUNCH_QUIRK are: westeros, bcmnexus");
+        WTFLogAlways("Supported quirks for WEBKIT_GST_HOLE_PUNCH_QUIRK are: fake, westeros, bcmnexus");
         return;
     }
 
@@ -135,6 +136,8 @@ GStreamerQuirksManager::GStreamerQuirksManager()
         m_holePunchQuirk = WTF::makeUnique<GStreamerHolePunchQuirkBcmNexus>();
     else if (WTF::equalLettersIgnoringASCIICase(holePunchQuirk, "westeros"_s))
         m_holePunchQuirk = WTF::makeUnique<GStreamerHolePunchQuirkWesteros>();
+    else if (WTF::equalLettersIgnoringASCIICase(holePunchQuirk, "fake"_s))
+        m_holePunchQuirk = WTF::makeUnique<GStreamerHolePunchQuirkFake>();
     else
         GST_WARNING("HolePunch quirk %s un-supported.", holePunchQuirk.ascii().data());
 }
@@ -161,8 +164,7 @@ GstElement* GStreamerQuirksManager::createWebAudioSink()
 
 GstElement* GStreamerQuirksManager::createHolePunchVideoSink(bool isLegacyPlaybin, const MediaPlayer* player)
 {
-    RELEASE_ASSERT_WITH_MESSAGE(isEnabled() && m_holePunchQuirk, "createHolePunchVideoSink() should be called only if one hole-punch quirk was requested");
-    if (!isEnabled() || !m_holePunchQuirk) {
+    if (!m_holePunchQuirk) {
         GST_DEBUG("None of the quirks requested a HolePunchSink");
         return nullptr;
     }