Skip to content

Commit 26ab43e

Browse files
committed
[GStreamer] Fix crash in event management
https://bugs.webkit.org/show_bug.cgi?id=294713 Reviewed by Philippe Normand. We were leaking the ref just in the line above for OOB events which was causing the quirks to try to use a nullptr. * Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp: (webKitMediaSrcSendEvent): Canonical link: https://commits.webkit.org/296413@main
1 parent 4bfe2af commit 26ab43e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,7 @@ static gboolean webKitMediaSrcSendEvent(GstElement* element, GstEvent* eventTran
851851
wasEventHandledByAnyStream |= wasHandled;
852852
}
853853
} else
854-
wasEventHandledByAnyStream = GST_ELEMENT_CLASS(webkit_media_src_parent_class)->send_event(element, event.leakRef());
854+
wasEventHandledByAnyStream = GST_ELEMENT_CLASS(webkit_media_src_parent_class)->send_event(element, event.ref());
855855
auto rate = GStreamerQuirksManager::singleton().processWebKitMediaSrcCustomEvent(event, wasEventHandledByAnyStream, wasEventHandledByAllStreams);
856856
if (rate.has_value())
857857
source->priv->rate = rate.value();

0 commit comments

Comments
 (0)