Remove obsolete webrtc stats

https://bugs.webkit.org/show_bug.cgi?id=256645
rdar://109206360

Reviewed by Eric Carlson.

These stats are now removed from the spec, let's remove them from WebKit.

* LayoutTests/webrtc/candidate-stats.html:
* Source/WebCore/Modules/mediastream/RTCStatsReport.h:
* Source/WebCore/Modules/mediastream/RTCStatsReport.idl:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::fillRTCRTPStreamStats):
(WebCore::fillRTCCandidateStats):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
(WebCore::fillRtpStreamStats):
(WebCore::fillRTCIceCandidatePairStats):

Canonical link: https://commits.webkit.org/264013@main

Author: youennf

LayoutTests/webrtc/candidate-stats.html

@@ -26,15 +26,15 @@
     assert_true(!stats.address, "address is not exposed");
     assert_true(!stats.networkType, "networkType is not exposed");
 
-    assert_array_equals(Object.keys(stats), ["id","timestamp","type","candidateType","deleted","port","priority","protocol","transportId"], "local");
+    assert_array_equals(Object.keys(stats), ["id","timestamp","type","candidateType","port","priority","protocol","transportId"], "local");
 
     stats = await getTypedStats(firstConnection, "remote-candidate");
 
     // For now, we do not want to expose address or networkType.
     assert_true(!stats.address, "address is not exposed");
     assert_true(!stats.networkType, "networkType is not exposed");
 
-    assert_array_equals(Object.keys(stats), ["id","timestamp","type","candidateType","deleted","port","priority","protocol","transportId"], "remote");
+    assert_array_equals(Object.keys(stats), ["id","timestamp","type","candidateType","port","priority","protocol","transportId"], "remote");
 }, "ICE candidate data channel stats");
         </script>
     </body>

Source/WebCore/Modules/mediastream/RTCStatsReport.h

@@ -62,7 +62,6 @@ class RTCStatsReport : public RefCounted<RTCStatsReport> {
     struct RtpStreamStats : Stats {
         uint32_t ssrc { 0 };
         String kind;
-        String mediaType;
         String transportId;
         String codecId;
     };
@@ -257,7 +256,6 @@ class RTCStatsReport : public RefCounted<RTCStatsReport> {
         String localCandidateId;
         String remoteCandidateId;
         IceCandidatePairState state;
-        std::optional<uint64_t> priority;
         std::optional<bool> nominated;
         std::optional<bool> writable;
         std::optional<bool> readable;
@@ -287,7 +285,6 @@ class RTCStatsReport : public RefCounted<RTCStatsReport> {
         std::optional<RTCIceCandidateType> candidateType;
         std::optional<int32_t> priority;
         String url;
-        bool deleted { false };
     };
 
     struct CertificateStats : Stats {

Source/WebCore/Modules/mediastream/RTCStatsReport.idl

@@ -60,8 +60,6 @@ dictionary RTCStats {
 dictionary RTCRtpStreamStats : RTCStats {
     required unsigned long ssrc;
     required DOMString kind;
-    // We should obsolete this field
-    required DOMString mediaType;
     DOMString transportId;
     DOMString codecId;
 };
@@ -258,7 +256,6 @@ dictionary RTCIceCandidatePairStats : RTCStats {
     DOMString localCandidateId;
     DOMString remoteCandidateId;
     RTCStatsIceCandidatePairState state;
-    unsigned long long priority;
     boolean nominated;
     boolean writable;
     boolean readable;
@@ -286,7 +283,6 @@ dictionary RTCIceCandidateStats : RTCStats {
     RTCIceCandidateType candidateType;
     long priority;
     DOMString url;
-    boolean deleted = false;
 };
 
 [ JSGenerateToJSObject ]
@@ -366,5 +362,3 @@ dictionary RTCVideoSourceStats : RTCMediaSourceStats {
     unsigned long frames;
     double framesPerSecond;
 };
-
-// FIXME 169662: missing RTCMediaStreamStats

Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp

@@ -57,10 +57,8 @@ static inline void fillRTCRTPStreamStats(RTCStatsReport::RtpStreamStats& stats,
     if (gst_structure_get_uint(structure, "ssrc", &value))
         stats.ssrc = value;
 
-    if (const char* kind = gst_structure_get_string(structure, "kind")) {
+    if (const char* kind = gst_structure_get_string(structure, "kind"))
         stats.kind = String::fromLatin1(kind);
-        stats.mediaType = stats.kind;
-    }
 }
 
 static inline void fillRTCCodecStats(RTCStatsReport::CodecStats& stats, const GstStructure* structure)
@@ -275,10 +273,6 @@ static inline void fillRTCCandidateStats(RTCStatsReport::IceCandidateStats& stat
 
     auto candidateType = String::fromLatin1(gst_structure_get_string(structure, "candidate-type"));
     stats.candidateType = iceCandidateType(candidateType);
-
-    uint64_t priority;
-    if (gst_structure_get_uint64(structure, "priority", &priority))
-        stats.priority = priority;
 }
 
 static inline void fillRTCCandidatePairStats(RTCStatsReport::IceCandidatePairStats& stats, const GstStructure* structure)

Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp

@@ -66,10 +66,8 @@ static inline void fillRtpStreamStats(RTCStatsReport::RtpStreamStats& stats, con
         stats.transportId = fromStdString(*rtcStats.transport_id);
     if (rtcStats.codec_id.is_defined())
         stats.codecId = fromStdString(*rtcStats.codec_id);
-    if (rtcStats.media_type.is_defined()) {
-        stats.mediaType = fromStdString(*rtcStats.media_type);
-        stats.kind = stats.mediaType;
-    }
+    if (rtcStats.media_type.is_defined())
+        stats.kind = fromStdString(*rtcStats.kind);
 }
 
 static inline void fillReceivedRtpStreamStats(RTCStatsReport::ReceivedRtpStreamStats& stats, const webrtc::RTCReceivedRtpStreamStats& rtcStats)
@@ -366,8 +364,6 @@ static inline void fillRTCIceCandidatePairStats(RTCStatsReport::IceCandidatePair
     if (rtcStats.state.is_defined())
         stats.state = iceCandidatePairState(*rtcStats.state);
 
-    if (rtcStats.priority.is_defined())
-        stats.priority = *rtcStats.priority;
     if (rtcStats.nominated.is_defined())
         stats.nominated = *rtcStats.nominated;
     if (rtcStats.writable.is_defined())