[GStreamer] Change isGStreamerPluginAvailable to ASCIILiteral

https://bugs.webkit.org/show_bug.cgi?id=289942

Reviewed by Philippe Normand.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::createGStreamerPeerConnectionBackend):
* Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(webKitGLVideoSinkProbePlatform):
* Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp:
(WebCore::GStreamerAudioMixer::isAvailable):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::isGStreamerPluginAvailable):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
* Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webKitTextCombinerHandleCaps):
(webkitTextCombinerNew):
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp:
(WebCore::MediaRecorderPrivateBackend::containerProfile):

Canonical link: https://commits.webkit.org/292299@main

Signed-off-by: Xabier Rodriguez Calvar <calvaris@igalia.com>

Author: calvaris

Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp

@@ -76,7 +76,7 @@ static std::unique_ptr<PeerConnectionBackend> createGStreamerPeerConnectionBacke
     std::call_once(debugRegisteredFlag, [] {
         GST_DEBUG_CATEGORY_INIT(webkit_webrtc_pc_backend_debug, "webkitwebrtcpeerconnection", 0, "WebKit WebRTC PeerConnection");
     });
-    if (!isGStreamerPluginAvailable("webrtc")) {
+    if (!isGStreamerPluginAvailable("webrtc"_s)) {
         WTFLogAlways("GstWebRTC plugin not found. Make sure to install gst-plugins-bad >= 1.20 with the webrtc plugin enabled.");
         return nullptr;
     }

Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp

@@ -195,7 +195,7 @@ bool webKitDMABufVideoSinkIsEnabled()
 
 bool webKitDMABufVideoSinkProbePlatform()
 {
-    return webkitGstCheckVersion(1, 20, 0) && isGStreamerPluginAvailable("app");
+    return webkitGstCheckVersion(1, 20, 0) && isGStreamerPluginAvailable("app"_s);
 }
 
 void webKitDMABufVideoSinkSetMediaPlayerPrivate(WebKitDMABufVideoSink* sink, MediaPlayerPrivateGStreamer* player)

Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp

@@ -195,7 +195,7 @@ bool webKitGLVideoSinkProbePlatform()
         return false;
     }
 
-    return isGStreamerPluginAvailable("app") && isGStreamerPluginAvailable("opengl");
+    return isGStreamerPluginAvailable("app"_s) && isGStreamerPluginAvailable("opengl"_s);
 }
 
 #undef GST_CAT_DEFAULT

Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp

@@ -32,7 +32,7 @@ GST_DEBUG_CATEGORY_STATIC(webkit_media_gst_audio_mixer_debug);
 
 bool GStreamerAudioMixer::isAvailable()
 {
-    return isGStreamerPluginAvailable("inter") && isGStreamerPluginAvailable("audiomixer");
+    return isGStreamerPluginAvailable("inter"_s) && isGStreamerPluginAvailable("audiomixer"_s);
 }
 
 GStreamerAudioMixer& GStreamerAudioMixer::singleton()

Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

@@ -935,11 +935,11 @@ Vector<uint8_t> GstMappedBuffer::createVector() const
     return std::span<const uint8_t> { data(), size() };
 }
 
-bool isGStreamerPluginAvailable(const char* name)
+bool isGStreamerPluginAvailable(ASCIILiteral name)
 {
-    GRefPtr<GstPlugin> plugin = adoptGRef(gst_registry_find_plugin(gst_registry_get(), name));
+    GRefPtr<GstPlugin> plugin = adoptGRef(gst_registry_find_plugin(gst_registry_get(), name.characters()));
     if (!plugin)
-        GST_WARNING("Plugin %s not found. Please check your GStreamer installation", name);
+        GST_WARNING("Plugin %s not found. Please check your GStreamer installation", name.characters());
     return plugin;
 }
 

Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h

@@ -269,7 +269,7 @@ void disconnectSimpleBusMessageCallback(GstElement*);
 
 enum class GstVideoDecoderPlatform { ImxVPU, Video4Linux, OpenMAX };
 
-bool isGStreamerPluginAvailable(const char* name);
+bool isGStreamerPluginAvailable(ASCIILiteral name);
 bool gstElementFactoryEquals(GstElement*, ASCIILiteral name);
 
 GstElement* createAutoAudioSink(const String& role);

Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp

@@ -87,7 +87,7 @@ void webKitTextCombinerHandleCaps(WebKitTextCombiner* combiner, GstPad* pad, con
             gst_pad_link(srcPad.get(), internalPad.get());
         } // Else: pipeline is already correct.
     } else if (gst_caps_can_intersect(cea608Caps.get(), caps)) {
-        if (!isGStreamerPluginAvailable("rsclosedcaption") || !isGStreamerPluginAvailable("closedcaption")) {
+        if (!isGStreamerPluginAvailable("rsclosedcaption"_s) || !isGStreamerPluginAvailable("closedcaption"_s)) {
             WTFLogAlways("GStreamer closedcaption plugins are missing. Please install gst-plugins-bad and gst-plugins-rs");
             return;
         }
@@ -218,7 +218,7 @@ static void webkit_text_combiner_class_init(WebKitTextCombinerClass* klass)
 GstElement* webkitTextCombinerNew()
 {
     // The combiner relies on webvttenc, fail early if it's not there.
-    if (!isGStreamerPluginAvailable("subenc")) {
+    if (!isGStreamerPluginAvailable("subenc"_s)) {
         WTFLogAlways("WebKit wasn't able to find a WebVTT encoder. Subtitles handling will be degraded unless gst-plugins-bad is installed.");
         return nullptr;
     }

Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp

@@ -271,7 +271,7 @@ GRefPtr<GstEncodingContainerProfile> MediaRecorderPrivateBackend::containerProfi
     if (scanner.isContentTypeSupported(GStreamerRegistryScanner::Configuration::Encoding, contentType, { }) == MediaPlayerEnums::SupportsType::IsNotSupported)
         return nullptr;
 
-    auto mp4Variant = isGStreamerPluginAvailable("fmp4") ? "iso-fragmented"_s : "iso"_s;
+    auto mp4Variant = isGStreamerPluginAvailable("fmp4"_s) ? "iso-fragmented"_s : "iso"_s;
     StringBuilder containerCapsDescriptionBuilder;
     auto containerType = contentType.containerType();
     if (containerType.endsWith("mp4"_s))