Skip to content

Commit 416b31a

Browse files
Ahmad Saleemcadubentzen
authored andcommitted
m_maxMessageSize should be infinity() instead of max() in RTCSctpTransport.h
https://bugs.webkit.org/show_bug.cgi?id=274025 rdar://problem/128306030 Reviewed by Youenn Fablet. This patch aligns WebKit with web specification [1]: [1] https://w3c.github.io/webrtc-pc/#dfn-update-the-data-max-message-size "If both remoteMaxMessageSize and canSendSize are 0, set [[MaxMessageSize]] to the positive Infinity value." * Source/WebCore/Modules/mediastream/RTCSctpTransport.h: (double m_maxMessageSize): * LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/279039@main
1 parent 77afee3 commit 416b31a

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

Source/WebCore/Modules/mediastream/RTCSctpTransport.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2021 Apple Inc. All rights reserved.
2+
* Copyright (C) 2021-2024 Apple Inc. All rights reserved.
33
*
44
* Redistribution and use in source and binary forms, with or without
55
* modification, are permitted provided that the following conditions
@@ -73,7 +73,8 @@ class RTCSctpTransport final : public RefCounted<RTCSctpTransport>, public Activ
7373
UniqueRef<RTCSctpTransportBackend> m_backend;
7474
Ref<RTCDtlsTransport> m_transport;
7575
RTCSctpTransportState m_state { RTCSctpTransportState::Connecting };
76-
double m_maxMessageSize { std::numeric_limits<double>::max() };
76+
// https://w3c.github.io/webrtc-pc/#dfn-update-the-data-max-message-size
77+
double m_maxMessageSize { std::numeric_limits<double>::infinity() };
7778
std::optional<unsigned short> m_maxChannels;
7879
};
7980

0 commit comments

Comments
 (0)