Skip to content

Commit 42177be

Browse files
committed
[GStreamer] Critical warning when updating video sink stats of a player in error state
This is a backport from https://commits.webkit.org/264718@main upstream. Reviewed by Xabier Rodriguez-Calvar. Don't attempt to gather video rendering metrics if the player hasn't created a video sink. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateVideoSinkStatistics): Canonical link: https://commits.webkit.org/264718@main
1 parent 531344b commit 42177be

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4221,6 +4221,9 @@ bool MediaPlayerPrivateGStreamer::updateVideoSinkStatistics()
42214221
uint64_t totalVideoFrames = 0;
42224222
uint64_t droppedVideoFrames = 0;
42234223
if (webkitGstCheckVersion(1, 18, 0)) {
4224+
if (!m_videoSink)
4225+
return false;
4226+
42244227
GUniqueOutPtr<GstStructure> stats;
42254228
g_object_get(m_videoSink.get(), "stats", &stats.outPtr(), nullptr);
42264229

0 commit comments

Comments
 (0)