[WebRTC] Use WebCore::LibWebRTCProvider by default

asurdej-comcast · philn · commit 5412776884e7 · 2024-05-08T12:40:47.000+01:00
Instead of Network LibWebRTCProvided to lower CPU usage.

Signed-off-by: Andrzej Surdej &lt;Andrzej_Surdej@comcast.com&gt;
diff --git a/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h b/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h
@@ -78,9 +78,12 @@ class LibWebRTCProvider final : public LibWebRTCProviderBase {
 #endif
 };
 
-inline UniqueRef<LibWebRTCProvider> createLibWebRTCProvider(WebPage& page)
+inline UniqueRef<LibWebRTCProviderBase> createLibWebRTCProvider(WebPage& page)
 {
-    return makeUniqueRef<LibWebRTCProvider>(page);
+    // In downstream WPEWebKit WebProcess sandbox is disabled,
+    // so moving LibWebRTC networking out of it doesn't make much sense.
+    // For better performance keep it in WPEWebProcess
+    return makeUniqueRef<LibWebRTCProviderBase>();
 }
 
 #elif USE(GSTREAMER_WEBRTC)

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,12 @@ class LibWebRTCProvider final : public LibWebRTCProviderBase {`
`78`	`78`	`#endif`
`79`	`79`	`};`
`80`	`80`
`81`		`-inline UniqueRef<LibWebRTCProvider> createLibWebRTCProvider(WebPage& page)`
	`81`	`+inline UniqueRef<LibWebRTCProviderBase> createLibWebRTCProvider(WebPage& page)`
`82`	`82`	`{`
`83`		`- return makeUniqueRef<LibWebRTCProvider>(page);`
	`83`	`+ // In downstream WPEWebKit WebProcess sandbox is disabled,`
	`84`	`+ // so moving LibWebRTC networking out of it doesn't make much sense.`
	`85`	`+ // For better performance keep it in WPEWebProcess`
	`86`	`+ return makeUniqueRef<LibWebRTCProviderBase>();`
`84`	`87`	`}`
`85`	`88`
`86`	`89`	`#elif USE(GSTREAMER_WEBRTC)`