[WPE][GTK] Fix several warnings when building for ARMv7 (32-bits)

https://bugs.webkit.org/show_bug.cgi?id=247873

Reviewed by Michael Catanzaro.

This fixes several warnings that appear when building for ARMv7 (32-bits):
 - deprecated-enum-enum-conversion
 - unused-variable
 - unused-result
 - overflow
 - sign-compare

It also disables two warnings for old versions of GCC
(old versions give false positives).

* PerformanceTests/MallocBench/MallocBench/stress_aligned.cpp:
(benchmark_stress_aligned):
* Source/JavaScriptCore/assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::revertJumpTo_movT3movtcmpT2):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4FourFours):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4Reg4Imm12):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg4Reg4Reg4Imm8):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg40Imm3Reg4Imm20Imm5):
* Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::characterIndex const):
(WebCore::AccessibilityObjectAtspi::selectionChanged):
* Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp:
(WebCore::FECompositeSoftwareApplier::applyArithmetic const):
* Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h:
(WebCore::DMABufReleaseFlag::release):
* Source/cmake/WebKitCompilerFlags.cmake:

Canonical link: https://commits.webkit.org/256792@main

Author: clopez

PerformanceTests/MallocBench/MallocBench/stress_aligned.cpp

@@ -148,7 +148,7 @@ void benchmark_stress_aligned(CommandLine&)
 
     srandom(1); // For consistency between runs.
 
-    size_t limit = 0x00001ffffffffffful;
+    uint64_t limit = 0x00001ffffffffffful;
 
     for (size_t size = 0; size < limit; size = std::max(size, sizeof(void*)) * 2) {
         for (size_t alignment = sizeof(void*); alignment < limit; alignment *= 2) {

Source/JavaScriptCore/assembler/ARMv7Assembler.h

@@ -1372,7 +1372,7 @@ class ARMv7Assembler {
             twoWordOp5i6Imm4Reg4EncodedImmSecond(right, lo16),
             twoWordOp5i6Imm4Reg4EncodedImmFirst(OP_MOVT, hi16),
             twoWordOp5i6Imm4Reg4EncodedImmSecond(right, hi16),
-            static_cast<uint16_t>(OP_CMP_reg_T2 | left)
+            static_cast<uint16_t>(static_cast<uint16_t>(OP_CMP_reg_T2) | static_cast<uint16_t>(left))
         };
         performJITMemcpy(address, instruction, sizeof(uint16_t) * 5);
         cacheFlush(address, sizeof(uint16_t) * 5);
@@ -3037,7 +3037,7 @@ class ARMv7Assembler {
 
         ALWAYS_INLINE void twoWordOp12Reg4FourFours(OpcodeID1 op, RegisterID reg, FourFours ff)
         {
-            m_buffer.putShort(op | reg);
+            m_buffer.putShort(static_cast<uint16_t>(op) | static_cast<uint16_t>(reg));
             m_buffer.putShort(ff.m_u.value);
         }
 
@@ -3070,19 +3070,19 @@ class ARMv7Assembler {
 
         ALWAYS_INLINE void twoWordOp12Reg4Reg4Imm12(OpcodeID1 op, RegisterID reg1, RegisterID reg2, uint16_t imm)
         {
-            m_buffer.putShort(op | reg1);
+            m_buffer.putShort(static_cast<uint16_t>(op) | static_cast<uint16_t>(reg1));
             m_buffer.putShort((reg2 << 12) | imm);
         }
 
         ALWAYS_INLINE void twoWordOp12Reg4Reg4Reg4Imm8(OpcodeID1 op, RegisterID reg1, RegisterID reg2, RegisterID reg3, uint8_t imm)
         {
-            m_buffer.putShort(op | reg1);
+            m_buffer.putShort(static_cast<uint16_t>(op) | static_cast<uint16_t>(reg1));
             m_buffer.putShort((reg2 << 12) | (reg3 << 8) | imm);
         }
 
         ALWAYS_INLINE void twoWordOp12Reg40Imm3Reg4Imm20Imm5(OpcodeID1 op, RegisterID reg1, RegisterID reg2, uint16_t imm1, uint16_t imm2, uint16_t imm3)
         {
-            m_buffer.putShort(op | reg1);
+            m_buffer.putShort(static_cast<uint16_t>(op) | static_cast<uint16_t>(reg1));
             m_buffer.putShort((imm1 << 12) | (reg2 << 8) | (imm2 << 6) | imm3);
         }
 

Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp

@@ -523,7 +523,7 @@ std::optional<unsigned> AccessibilityObjectAtspi::characterIndex(UChar character
     if (utf8Text.isNull())
         return std::nullopt;
 
-    auto length = g_utf8_strlen(utf8Text.data(), -1);
+    auto length = static_cast<unsigned>(g_utf8_strlen(utf8Text.data(), -1));
     if (offset >= length)
         return std::nullopt;
 
@@ -744,7 +744,7 @@ void AccessibilityObjectAtspi::selectionChanged(const VisibleSelection& selectio
     if (bounds.y() < 0)
         return;
 
-    auto length = g_utf8_strlen(utf8Text.data(), -1);
+    auto length = static_cast<unsigned>(g_utf8_strlen(utf8Text.data(), -1));
     auto mapping = offsetMapping(utf16Text);
     auto caretOffset = UTF16OffsetToUTF8(mapping, bounds.y());
     if (caretOffset <= length)

Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h

@@ -28,6 +28,8 @@
 
 #include <sys/eventfd.h>
 #include <wtf/Noncopyable.h>
+#include <wtf/SafeStrerror.h>
+#include <wtf/text/CString.h>
 #include <wtf/unix/UnixFileDescriptor.h>
 
 namespace WebCore {
@@ -72,7 +74,8 @@ struct DMABufReleaseFlag {
             return;
 
         uint64_t value { 1 };
-        write(fd.value(), &value, sizeof(uint64_t));
+        if (write(fd.value(), &value, sizeof(value)) != sizeof(value))
+            WTFLogAlways("Error writing to the eventfd at DMABufReleaseFlag: %s", safeStrerror(errno).data());
     }
 
     UnixFileDescriptor fd;

Source/cmake/WebKitCompilerFlags.cmake

@@ -129,6 +129,12 @@ if (COMPILER_IS_GCC_OR_CLANG)
                                          -Wno-misleading-indentation
                                          -Wno-psabi)
 
+    # GCC < 12.0 gives false warnings for mismatched-new-delete <https://webkit.org/b/241516>
+    if ((CMAKE_CXX_COMPILER_ID MATCHES "GNU") AND (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "12.0.0"))
+        WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Wno-mismatched-new-delete)
+        WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Wno-uninitialized)
+    endif ()
+
     WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-noexcept-type)
 
     # These GCC warnings produce too many false positives to be useful. We'll