[SOUP] WPENetworkProcess crashed on process exit

pgorszkowski-igalia · pgorszkowski-igalia · commit 78f5d8948a0d · 2025-04-23T11:50:05.000+02:00
https://bugs.webkit.org/show_bug.cgi?id=290446 Reviewed by Michael Catanzaro. To cancel all pending requests before network process exits, we have to abort the current soup session. This will cancell all pending cancellable task in glib-network backends (e.g.: OpenSSL, GnuTLS). Original author: Volodymyr Ogorodnik() See: #1482 * Source/WebCore/platform/network/soup/SoupNetworkSession.cpp: (WebCore::SoupNetworkSession::~SoupNetworkSession): Canonical link: https://commits.webkit.org/294000@main
diff --git a/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp b/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
@@ -152,7 +152,10 @@ SoupNetworkSession::SoupNetworkSession(PAL::SessionID sessionID)
     setupLogger();
 }
 
-SoupNetworkSession::~SoupNetworkSession() = default;
+SoupNetworkSession::~SoupNetworkSession()
+{
+    soup_session_abort(m_soupSession.get());
+}
 
 void SoupNetworkSession::setupLogger()
 {

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,10 @@ SoupNetworkSession::SoupNetworkSession(PAL::SessionID sessionID)`
`152`	`152`	`setupLogger();`
`153`	`153`	`}`
`154`	`154`
`155`		`-SoupNetworkSession::~SoupNetworkSession() = default;`
	`155`	`+SoupNetworkSession::~SoupNetworkSession()`
	`156`	`+{`
	`157`	`+ soup_session_abort(m_soupSession.get());`
	`158`	`+}`
`156`	`159`
`157`	`160`	`void SoupNetworkSession::setupLogger()`
`158`	`161`	`{`