Simplify some character-related code to ease future changes to Latin1Character

https://bugs.webkit.org/show_bug.cgi?id=299671
rdar://161487282

Reviewed by Sam Weinig.

* Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp:
(JSC::edgeTypeToNumber): Deleted.
(JSC::HeapSnapshotBuilder::json): Remove call to edgeTypeToNumber function so we can
serialize the edge type enumeration as a number. It's not needed because serialization
done by StringBuilder::append already serializes enumerations as their underlying=
numeric values.

* Source/WTF/wtf/HexNumber.cpp:
(WTF::Internal::hexDigitsForMode): Moved this function out of the header since it's
only used in this file.
* Source/WTF/wtf/HexNumber.h:
(WTF::Internal::hexDigitsForMode): Deleted.

* Source/WebCore/Modules/url-pattern/URLPatternParser.cpp:
(WebCore::URLPatternUtilities::escapeRegexStringForCharacters): Use an array of
CharacterType rather than an array of char.
(WebCore::URLPatternUtilities::escapePatternStringForCharacters): Ditto.

Canonical link: https://commits.webkit.org/300658@main

Signed-off-by: Xabier Rodriguez Calvar <calvaris@igalia.com>

Author: darinadler

Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp

@@ -351,11 +351,6 @@ enum class NodeFlags {
     ObjectSubtype = 1 << 1,
 };
 
-static uint8_t edgeTypeToNumber(EdgeType type)
-{
-    return static_cast<uint8_t>(type);
-}
-
 static ASCIILiteral edgeTypeToString(EdgeType type)
 {
     switch (type) {
@@ -530,7 +525,7 @@ void HeapSnapshotBuilder::writeJson(Function<bool (const HeapSnapshotNode&)>&& a
         firstEdge = false;
 
         // <fromNodeId>, <toNodeId>, <edgeTypeIndex>, <edgeExtraData>
-        json.append(edge.from.identifier, ',', edge.to.identifier, ',', edgeTypeToNumber(edge.type), ',');
+        json.append(edge.from.identifier, ',', edge.to.identifier, ',', edge.type, ',');
         switch (edge.type) {
         case EdgeType::Property:
         case EdgeType::Variable: {

Source/WTF/wtf/HexNumber.cpp

@@ -27,6 +27,13 @@ namespace WTF {
 
 namespace Internal {
 
+static const Latin1Character* hexDigitsForMode(HexConversionMode mode)
+{
+    static const Latin1Character lowercaseHexDigits[17] = "0123456789abcdef";
+    static const Latin1Character uppercaseHexDigits[17] = "0123456789ABCDEF";
+    return mode == Lowercase ? lowercaseHexDigits : uppercaseHexDigits;
+}
+
 std::pair<Latin1Character*, unsigned> appendHex(Latin1Character* buffer, unsigned bufferSize, std::uintmax_t number, unsigned minimumDigits, HexConversionMode mode)
 {
     auto end = buffer + bufferSize;

Source/WTF/wtf/HexNumber.h

@@ -29,13 +29,6 @@ enum HexConversionMode { Lowercase, Uppercase };
 
 namespace Internal {
 
-inline const Latin1Character* hexDigitsForMode(HexConversionMode mode)
-{
-    static const Latin1Character lowercaseHexDigits[17] = "0123456789abcdef";
-    static const Latin1Character uppercaseHexDigits[17] = "0123456789ABCDEF";
-    return mode == Lowercase ? lowercaseHexDigits : uppercaseHexDigits;
-}
-
 WTF_EXPORT_PRIVATE std::pair<Latin1Character*, unsigned> appendHex(Latin1Character* buffer, unsigned bufferSize, std::uintmax_t number, unsigned minimumDigits, HexConversionMode);
 
 template<size_t arraySize, typename NumberType>