Merge pull request #1227 from filipe-norte-red/wpe-2.38-xml-http-request-cache-disable-for-protocols

XMLHttpReques: allow disabling the cache for selected protocols

Author: magomez

Source/WebCore/xml/XMLHttpRequest.cpp

@@ -97,6 +97,29 @@ static void logConsoleError(ScriptExecutionContext* context, const String& messa
     context->addConsoleMessage(MessageSource::JS, MessageLevel::Error, message);
 }
 
+static bool shouldDisableCacheForRequest(URL& url)
+{
+    static Vector<String> s_protocolsNotCached;
+    static std::once_flag s_onceFlag;
+    std::call_once(s_onceFlag,
+        [] {
+            // The env var contains a comma separated list of protocols that need to disable the cache,
+            // for example WPE_DISABLE_XHR_RESPONSE_CACHING_FOR_PROTOCOLS="dvb,echo,file"
+            String s(String::fromLatin1(std::getenv("WPE_DISABLE_XHR_RESPONSE_CACHING_FOR_PROTOCOLS")));
+            if (!s.isEmpty()) {
+                s_protocolsNotCached.appendVector(s.split(','));
+            }
+        });
+
+    if (getenv("WPE_DISABLE_XHR_RESPONSE_CACHING"))
+        return true;
+
+    if (s_protocolsNotCached.contains(url.protocol().toString()))
+        return true;
+
+    return false;
+}
+
 Ref<XMLHttpRequest> XMLHttpRequest::create(ScriptExecutionContext& context)
 {
     auto xmlHttpRequest = adoptRef(*new XMLHttpRequest(context));
@@ -627,7 +650,7 @@ ExceptionOr<void> XMLHttpRequest::createRequest()
     options.filteringPolicy = ResponseFilteringPolicy::Enable;
     options.contentEncodingSniffingPolicy = ContentEncodingSniffingPolicy::Disable;
 
-    if (responseType() == ResponseType::Arraybuffer || getenv("WPE_DISABLE_XHR_RESPONSE_CACHING")) {
+    if (responseType() == ResponseType::Arraybuffer || shouldDisableCacheForRequest(m_url)) {
         options.dataBufferingPolicy = DataBufferingPolicy::DoNotBufferData;
         options.cachingPolicy = CachingPolicy::DisallowCaching;
         request.setCachePolicy(ResourceRequestCachePolicy::DoNotUseAnyCache);