Revert "Reduce use of Vector::uncheckedAppend() throughout the code base"

This reverts commit f0545c4.

Author: philn

Source/WTF/wtf/cf/LanguageCF.cpp

@@ -101,10 +101,12 @@ Vector<String> platformUserPreferredLanguages(ShouldMinimizeLanguages shouldMini
     if (!platformLanguagesCount)
         return { "en"_s };
 
-    Vector<String> languages(platformLanguagesCount, [&](size_t i) {
+    Vector<String> languages;
+    languages.reserveInitialCapacity(platformLanguagesCount);
+    for (CFIndex i = 0; i < platformLanguagesCount; i++) {
         auto platformLanguage = static_cast<CFStringRef>(CFArrayGetValueAtIndex(platformLanguages.get(), i));
-        return httpStyleLanguageCode(platformLanguage, shouldMinimizeLanguages);
-    });
+        languages.uncheckedAppend(httpStyleLanguageCode(platformLanguage, shouldMinimizeLanguages));
+    }
 
     LOG_WITH_STREAM(Language, stream << "After passing through httpStyleLanguageCode: " << languages);
 

Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp

@@ -62,12 +62,16 @@ static ExceptionOr<Vector<ListedChild>> listDirectoryWithMetadata(const String&
         return Exception { NotFoundError, "Path no longer exists or is no longer a directory"_s };
 
     auto childNames = FileSystem::listDirectory(fullPath);
-    return WTF::compactMap(WTFMove(childNames), [&](auto&& childName) -> std::optional<ListedChild> {
+    Vector<ListedChild> listedChildren;
+    listedChildren.reserveInitialCapacity(childNames.size());
+    for (auto& childName : childNames) {
         auto childPath = FileSystem::pathByAppendingComponent(fullPath, childName);
-        if (auto fileType = fileTypeIgnoringHiddenFiles(childPath))
-            return ListedChild { WTFMove(childName), *fileType };
-        return std::nullopt;
-    });
+        auto fileType = fileTypeIgnoringHiddenFiles(childPath);
+        if (!fileType)
+            continue;
+        listedChildren.uncheckedAppend(ListedChild { childName, *fileType });
+    }
+    return listedChildren;
 }
 
 static ExceptionOr<Vector<Ref<FileSystemEntry>>> toFileSystemEntries(ScriptExecutionContext& context, DOMFileSystem& fileSystem, ExceptionOr<Vector<ListedChild>>&& listedChildren, const String& parentVirtualPath)
@@ -76,18 +80,22 @@ static ExceptionOr<Vector<Ref<FileSystemEntry>>> toFileSystemEntries(ScriptExecu
     if (listedChildren.hasException())
         return listedChildren.releaseException();
 
-    return WTF::compactMap(listedChildren.returnValue(), [&](auto& child) -> RefPtr<FileSystemEntry> {
+    Vector<Ref<FileSystemEntry>> entries;
+    entries.reserveInitialCapacity(listedChildren.returnValue().size());
+    for (auto& child : listedChildren.returnValue()) {
         String virtualPath = parentVirtualPath + "/" + child.filename;
         switch (child.type) {
         case FileSystem::FileType::Regular:
-            return FileSystemFileEntry::create(context, fileSystem, virtualPath);
+            entries.uncheckedAppend(FileSystemFileEntry::create(context, fileSystem, virtualPath));
+            break;
         case FileSystem::FileType::Directory:
-            return FileSystemDirectoryEntry::create(context, fileSystem, virtualPath);
+            entries.uncheckedAppend(FileSystemDirectoryEntry::create(context, fileSystem, virtualPath));
+            break;
         default:
             break;
         }
-        return nullptr;
-    });
+    }
+    return entries;
 }
 
 // https://wicg.github.io/entries-api/#name

Source/WebCore/Modules/gamepad/Gamepad.cpp

@@ -43,9 +43,9 @@ Gamepad::Gamepad(const PlatformGamepad& platformGamepad)
     , m_axes(platformGamepad.axisValues().size(), 0.0)
 {
     unsigned buttonCount = platformGamepad.buttonValues().size();
-    m_buttons = Vector<Ref<GamepadButton>>(buttonCount, [](size_t) {
-        return GamepadButton::create();
-    });
+    m_buttons.reserveInitialCapacity(buttonCount);
+    for (unsigned i = 0; i < buttonCount; ++i)
+        m_buttons.uncheckedAppend(GamepadButton::create());
 }
 
 Gamepad::~Gamepad() = default;

Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp

@@ -87,9 +87,9 @@ RTCEncodedAudioFrameMetadata LibWebRTCRtpTransformableFrame::audioMetadata() con
     if (!m_isAudioSenderFrame) {
         auto* audioFrame = static_cast<webrtc::TransformableAudioFrameInterface*>(m_rtcFrame.get());
         auto contributingSources = audioFrame->GetContributingSources();
-        cssrcs = Vector<uint32_t>(contributingSources.size(), [&](size_t cptr) {
-            return contributingSources[cptr];
-        });
+        cssrcs.reserveInitialCapacity(contributingSources.size());
+        for (size_t cptr = 0; cptr < contributingSources.size(); ++cptr)
+            cssrcs.uncheckedAppend(contributingSources[cptr]);
     }
     return { m_rtcFrame->GetSsrc(), WTFMove(cssrcs) };
 }