[GStreamer] Switch setGstElementGLContext to ASCIILiteral

https://bugs.webkit.org/show_bug.cgi?id=290049

Reviewed by Philippe Normand.

* Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(webKitGLVideoSinkChangeState):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::setGstElementGLContext):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
* Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameConverter.cpp:
(WebCore::GStreamerVideoFrameConverter::Pipeline::run):

Canonical link: https://commits.webkit.org/292373@main

Signed-off-by: Xabier Rodriguez Calvar <calvaris@igalia.com>

Author: calvaris

Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp

@@ -131,9 +131,10 @@ static GstStateChangeReturn webKitGLVideoSinkChangeState(GstElement* element, Gs
     case GST_STATE_CHANGE_NULL_TO_READY:
     case GST_STATE_CHANGE_READY_TO_READY:
     case GST_STATE_CHANGE_READY_TO_PAUSED: {
-        if (!setGstElementGLContext(element, GST_GL_DISPLAY_CONTEXT_TYPE))
+        static ASCIILiteral gstGlDisplayContextyType = ASCIILiteral::fromLiteralUnsafe(GST_GL_DISPLAY_CONTEXT_TYPE);
+        if (!setGstElementGLContext(element, gstGlDisplayContextyType))
             return GST_STATE_CHANGE_FAILURE;
-        if (!setGstElementGLContext(element, "gst.gl.app_context"))
+        if (!setGstElementGLContext(element, "gst.gl.app_context"_s))
             return GST_STATE_CHANGE_FAILURE;
         break;
     }

Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

@@ -1866,11 +1866,11 @@ static std::optional<GRefPtr<GstContext>> requestGLContext(const char* contextTy
     return std::nullopt;
 }
 
-bool setGstElementGLContext(GstElement* element, const char* contextType)
+bool setGstElementGLContext(GstElement* element, ASCIILiteral contextType)
 {
-    GRefPtr<GstContext> oldContext = adoptGRef(gst_element_get_context(element, contextType));
+    GRefPtr<GstContext> oldContext = adoptGRef(gst_element_get_context(element, contextType.characters()));
     if (!oldContext) {
-        auto newContext = requestGLContext(contextType);
+        auto newContext = requestGLContext(contextType.characters());
         if (!newContext)
             return false;
         gst_element_set_context(element, newContext->get());

Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h

@@ -356,7 +356,7 @@ WARN_UNUSED_RETURN GRefPtr<GstCaps> buildDMABufCaps();
 #endif
 
 #if USE(GSTREAMER_GL)
-bool setGstElementGLContext(GstElement*, const char* contextType);
+bool setGstElementGLContext(GstElement*, ASCIILiteral contextType);
 #endif
 
 } // namespace WebCore