LibWebRTCMediaEndpoint sessionDescriptionType should return a value in all cases.

youennf · magomez · commit b3d92561c3dc · 2023-11-08T10:06:41.000+01:00
https://bugs.webkit.org/show_bug.cgi?id=245433 rdar://100044704 Reviewed by Eric Carlson. * Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::sessionDescriptionType): Canonical link: https://commits.webkit.org/254693@main
diff --git a/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp b/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
@@ -141,6 +141,8 @@ static inline webrtc::SdpType sessionDescriptionType(RTCSdpType sdpType)
     case RTCSdpType::Rollback:
         return webrtc::SdpType::kRollback;
     }
+    ASSERT_NOT_REACHED();
+    return webrtc::SdpType::kOffer;
 }
 
 void LibWebRTCMediaEndpoint::doSetLocalDescription(const RTCSessionDescription* description)

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,8 @@ static inline webrtc::SdpType sessionDescriptionType(RTCSdpType sdpType)`
`141`	`141`	`case RTCSdpType::Rollback:`
`142`	`142`	`return webrtc::SdpType::kRollback;`
`143`	`143`	`}`
	`144`	`+ ASSERT_NOT_REACHED();`
	`145`	`+ return webrtc::SdpType::kOffer;`
`144`	`146`	`}`
`145`	`147`
`146`	`148`	`void LibWebRTCMediaEndpoint::doSetLocalDescription(const RTCSessionDescription* description)`