Quirks: Fix fake hole-punching

Author: philn

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -192,6 +192,9 @@ MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer(MediaPlayer* player)
 #if USE(TEXTURE_MAPPER_GL) && USE(NICOSIA)
     m_nicosiaLayer = Nicosia::ContentLayer::create(Nicosia::ContentLayerTextureMapperImpl::createFactory(*this,
         [&]() -> Ref<TextureMapperPlatformLayerProxy> {
+            if (isHolePunchRenderingEnabled())
+                return adoptRef(*new TextureMapperPlatformLayerProxyGL(true));
+
 #if USE(TEXTURE_MAPPER_DMABUF)
             if (webKitDMABufVideoSinkIsEnabled() && webKitDMABufVideoSinkProbePlatform())
                 return adoptRef(*new TextureMapperPlatformLayerProxyDMABuf);

Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp

@@ -175,8 +175,7 @@ GstElement* GStreamerQuirksManager::createHolePunchVideoSink(bool isLegacyPlaybi
 
 void GStreamerQuirksManager::setHolePunchVideoRectangle(GstElement* videoSink, const IntRect& rect)
 {
-    RELEASE_ASSERT_WITH_MESSAGE(isEnabled() && m_holePunchQuirk, "setHolePunchVideoRectangle() should be called only if one hole-punch quirk was requested");
-    if (!isEnabled() || !m_holePunchQuirk) {
+    if (!m_holePunchQuirk) {
         GST_DEBUG("None of the quirks requested a HolePunchSink");
         return;
     }