Skip to content

Commit c89f56d

Browse files
suresh-khurdiya-infosyseocanha
authored andcommitted
[GStreamer] Account for internal pauses because of buffering
https://bugs.webkit.org/show_bug.cgi?id=287881 Reviewed by Xabier Rodriguez-Calvar. The original patch[1] needs a follow-up to ensure that the simulated paused state because of buffering isn't reported to the upper layers as a formal pause (requested by the user). Author: suresh-khurdiya-infosys <skhurdiya.ext@libertyglobal.com> [1] https://commits.webkit.org/290606@main * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::paused const): Early bail out (returning false, meaning "not paused") also when we're simulating a pause internally because of waiting for buffering. Canonical link: https://commits.webkit.org/290782@main
1 parent 2b361c9 commit c89f56d

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,8 +484,9 @@ bool MediaPlayerPrivateGStreamer::paused() const
484484
}
485485

486486
if (m_playbackRatePausedState == PlaybackRatePausedState::RatePaused
487-
|| m_playbackRatePausedState == PlaybackRatePausedState::ShouldMoveToPlaying) {
488-
GST_DEBUG_OBJECT(pipeline(), "Playback rate is 0, simulating PAUSED state");
487+
|| m_playbackRatePausedState == PlaybackRatePausedState::ShouldMoveToPlaying
488+
|| m_playbackRatePausedState == PlaybackRatePausedState::BufferingPaused) {
489+
GST_DEBUG_OBJECT(pipeline(), "Playback rate is 0 or paused for buffering, simulating PAUSED state");
489490
return false;
490491
}
491492

0 commit comments

Comments
 (0)