Skip to content

Commit ee7cd86

Browse files
[GTK/WPE] Web Inspector: crash in remote web inspector when connection closed during data transfer
https://bugs.webkit.org/show_bug.cgi?id=265304 Reviewed by Carlos Garcia Campos. It seems that after closing remote web inspector connection it is possible that some of messages can be still sent from WebProcess to UIProcess and in RemoteInspectorServer::sendMessageToFrontend there can be a crash because of missing socketConnection which was removed by previous closing remote web inspector connection(RemoteInspectorServer::close). * Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp: (Inspector::RemoteInspectorServer::sendMessageToFrontend): Canonical link: https://commits.webkit.org/271097@main
1 parent 3baf50e commit ee7cd86

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,9 @@ void RemoteInspectorServer::sendMessageToFrontend(SocketConnection& remoteInspec
326326

327327
uint64_t connectionID = m_remoteInspectorConnectionToIDMap.get(&remoteInspectorConnection);
328328
auto connectionTargetPair = std::make_pair(connectionID, targetID);
329-
ASSERT(m_automationTargets.contains(connectionTargetPair) || m_inspectionTargets.contains(connectionTargetPair));
329+
if (!m_automationTargets.contains(connectionTargetPair) && !m_inspectionTargets.contains(connectionTargetPair))
330+
return;
331+
330332
SocketConnection* clientConnection = m_inspectionTargets.contains(connectionTargetPair) ? m_clientConnection : m_automationConnection;
331333
ASSERT(clientConnection);
332334
clientConnection->sendMessage("SendMessageToFrontend", g_variant_new("(tt&s)", connectionID, targetID, message));

0 commit comments

Comments
 (0)