Reduce use of Vector::uncheckedAppend() throughout the code base

https://bugs.webkit.org/show_bug.cgi?id=262602

Reviewed by Brent Fulgham.

* Source/WTF/wtf/cf/LanguageCF.cpp:
(WTF::platformUserPreferredLanguages):
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.mm:
(WebCore::ShapeDetection::BarcodeDetectorImpl::getSupportedFormats):
* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::GPUQueue::submit):
* Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp:
(WebCore::GPURenderPassEncoder::executeBundles):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::DeviceImpl::createBindGroupLayout):
(WebCore::WebGPU::convertToBacking):
* Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::listDirectoryWithMetadata):
(WebCore::toFileSystemEntries):
* Source/WebCore/Modules/gamepad/Gamepad.cpp:
* Source/WebCore/Modules/highlight/Highlight.cpp:
(WebCore::Highlight::Highlight):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::toLibWebRTCMediaEndpointTransceiverState):
(WebCore::transceiverStatesFromPeerConnection):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:
(WebCore::LibWebRTCRtpTransformableFrame::audioMetadata const):

Canonical link: https://commits.webkit.org/268874@main

Author: cdumez

Source/WTF/wtf/cf/LanguageCF.cpp

@@ -101,12 +101,10 @@ Vector<String> platformUserPreferredLanguages(ShouldMinimizeLanguages shouldMini
     if (!platformLanguagesCount)
         return { "en"_s };
 
-    Vector<String> languages;
-    languages.reserveInitialCapacity(platformLanguagesCount);
-    for (CFIndex i = 0; i < platformLanguagesCount; i++) {
+    Vector<String> languages(platformLanguagesCount, [&](size_t i) {
         auto platformLanguage = static_cast<CFStringRef>(CFArrayGetValueAtIndex(platformLanguages.get(), i));
-        languages.uncheckedAppend(httpStyleLanguageCode(platformLanguage, shouldMinimizeLanguages));
-    }
+        return httpStyleLanguageCode(platformLanguage, shouldMinimizeLanguages);
+    });
 
     LOG_WITH_STREAM(Language, stream << "After passing through httpStyleLanguageCode: " << languages);
 

Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp

@@ -62,16 +62,12 @@ static ExceptionOr<Vector<ListedChild>> listDirectoryWithMetadata(const String&
         return Exception { NotFoundError, "Path no longer exists or is no longer a directory"_s };
 
     auto childNames = FileSystem::listDirectory(fullPath);
-    Vector<ListedChild> listedChildren;
-    listedChildren.reserveInitialCapacity(childNames.size());
-    for (auto& childName : childNames) {
+    return WTF::compactMap(WTFMove(childNames), [&](auto&& childName) -> std::optional<ListedChild> {
         auto childPath = FileSystem::pathByAppendingComponent(fullPath, childName);
-        auto fileType = fileTypeIgnoringHiddenFiles(childPath);
-        if (!fileType)
-            continue;
-        listedChildren.uncheckedAppend(ListedChild { childName, *fileType });
-    }
-    return listedChildren;
+        if (auto fileType = fileTypeIgnoringHiddenFiles(childPath))
+            return ListedChild { WTFMove(childName), *fileType };
+        return std::nullopt;
+    });
 }
 
 static ExceptionOr<Vector<Ref<FileSystemEntry>>> toFileSystemEntries(ScriptExecutionContext& context, DOMFileSystem& fileSystem, ExceptionOr<Vector<ListedChild>>&& listedChildren, const String& parentVirtualPath)
@@ -80,22 +76,18 @@ static ExceptionOr<Vector<Ref<FileSystemEntry>>> toFileSystemEntries(ScriptExecu
     if (listedChildren.hasException())
         return listedChildren.releaseException();
 
-    Vector<Ref<FileSystemEntry>> entries;
-    entries.reserveInitialCapacity(listedChildren.returnValue().size());
-    for (auto& child : listedChildren.returnValue()) {
+    return WTF::compactMap(listedChildren.returnValue(), [&](auto& child) -> RefPtr<FileSystemEntry> {
         String virtualPath = parentVirtualPath + "/" + child.filename;
         switch (child.type) {
         case FileSystem::FileType::Regular:
-            entries.uncheckedAppend(FileSystemFileEntry::create(context, fileSystem, virtualPath));
-            break;
+            return FileSystemFileEntry::create(context, fileSystem, virtualPath);
         case FileSystem::FileType::Directory:
-            entries.uncheckedAppend(FileSystemDirectoryEntry::create(context, fileSystem, virtualPath));
-            break;
+            return FileSystemDirectoryEntry::create(context, fileSystem, virtualPath);
         default:
             break;
         }
-    }
-    return entries;
+        return nullptr;
+    });
 }
 
 // https://wicg.github.io/entries-api/#name

Source/WebCore/Modules/gamepad/Gamepad.cpp

@@ -43,9 +43,9 @@ Gamepad::Gamepad(const PlatformGamepad& platformGamepad)
     , m_axes(platformGamepad.axisValues().size(), 0.0)
 {
     unsigned buttonCount = platformGamepad.buttonValues().size();
-    m_buttons.reserveInitialCapacity(buttonCount);
-    for (unsigned i = 0; i < buttonCount; ++i)
-        m_buttons.uncheckedAppend(GamepadButton::create());
+    m_buttons = Vector<Ref<GamepadButton>>(buttonCount, [](size_t) {
+        return GamepadButton::create();
+    });
 }
 
 Gamepad::~Gamepad() = default;

Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp

@@ -88,9 +88,9 @@ RTCEncodedAudioFrameMetadata LibWebRTCRtpTransformableFrame::audioMetadata() con
         auto* audioFrame = static_cast<webrtc::TransformableAudioFrameInterface*>(m_rtcFrame.get());
         auto& header = audioFrame->GetHeader();
         if (header.numCSRCs) {
-            cssrcs.reserveInitialCapacity(header.numCSRCs);
-            for (size_t cptr = 0; cptr < header.numCSRCs; ++cptr)
-                cssrcs.uncheckedAppend(header.arrOfCSRCs[cptr]);
+            cssrcs = Vector<uint32_t>(header.numCSRCs, [&](size_t cptr) {
+                return header.arrOfCSRCs[cptr];
+            });
         }
     }
     return { m_rtcFrame->GetSsrc(), WTFMove(cssrcs) };