Quirks: Add quirk for sink clock sync'ing

Author: philn

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -1038,12 +1038,12 @@ static void setSyncOnClock(GstElement* element, bool sync)
 
 void MediaPlayerPrivateGStreamer::syncOnClock(bool sync)
 {
-#if !USE(WESTEROS_SINK)
+    auto& quirksManager = GStreamerQuirksManager::singleton();
+    if (quirksManager.supportsVideoHolePunchRendering() && !quirksManager.sinksRequireClockSynchronization())
+        return;
+
     setSyncOnClock(videoSink(), sync);
     setSyncOnClock(audioSink(), sync);
-#else
-    UNUSED_PARAM(sync);
-#endif
 }
 
 template <typename TrackPrivateType>

Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkWesteros.h

@@ -32,6 +32,7 @@ class GStreamerHolePunchQuirkWesteros final : public GStreamerHolePunchQuirk {
 
     GstElement* createHolePunchVideoSink(bool, const MediaPlayer*) final;
     bool setHolePunchVideoRectangle(GstElement*, const IntRect&) final;
+    bool requiresClockSynchronization() const final { return false; }
 };
 
 } // namespace WebCore

Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp

@@ -192,6 +192,14 @@ void GStreamerQuirksManager::setHolePunchVideoRectangle(GstElement* videoSink, c
         GST_WARNING("Hole punch video rectangle configuration failed.");
 }
 
+bool GStreamerQuirksManager::sinksRequireClockSynchronization() const
+{
+    if (!m_holePunchQuirk)
+        return true;
+
+    return m_holePunchQuirk->requiresClockSynchronization();
+}
+
 void GStreamerQuirksManager::configureElement(GstElement* element, OptionSet<ElementRuntimeCharacteristics>&& characteristics)
 {
     GST_DEBUG("Configuring element %" GST_PTR_FORMAT, element);

Source/WebCore/platform/gstreamer/GStreamerQuirks.h

@@ -69,6 +69,7 @@ class GStreamerHolePunchQuirk : public GStreamerQuirkBase {
 
     virtual GstElement* createHolePunchVideoSink(bool, const MediaPlayer*) { return nullptr; }
     virtual bool setHolePunchVideoRectangle(GstElement*, const IntRect&) { return false; }
+    virtual bool requiresClockSynchronization() const { return true; }
 };
 
 class GStreamerQuirksManager : public RefCounted<GStreamerQuirksManager> {
@@ -94,6 +95,7 @@ class GStreamerQuirksManager : public RefCounted<GStreamerQuirksManager> {
     bool supportsVideoHolePunchRendering() const;
     GstElement* createHolePunchVideoSink(bool isLegacyPlaybin, const MediaPlayer*);
     void setHolePunchVideoRectangle(GstElement*, const IntRect&);
+    bool sinksRequireClockSynchronization() const;
 
     void setHolePunchEnabledForTesting(bool);