Skip to content

Commit eb047dc

Browse files
authored
Merge pull request #555 from oxixes/fix-preferences
Fix preference remaining in an invalid state
2 parents 7b14f55 + 64b8229 commit eb047dc

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/wirecloud/platform/static/js/wirecloud/Preferences.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,16 +92,19 @@
9292
const changes = utils.clone(newValues[name]);
9393
let changed = false;
9494

95+
let isInheriting = preference.inherit;
96+
9597
if ('inherit' in changes) {
9698
if (preference.inherit !== changes.inherit) {
99+
isInheriting = changes.inherit;
97100
changed = persist = true;
98101
} else {
99102
delete changes.inherit;
100103
}
101104
}
102105

103106
if ('value' in changes) {
104-
if (preference.value !== changes.value) {
107+
if (preference.value !== changes.value || (!isInheriting && changed)) {
105108
changed = persist = true;
106109
changes.value = Wirecloud.ui.InputInterfaceFactory.stringify(preference.meta.options.type, changes.value);
107110
} else {

0 commit comments

Comments
 (0)