Skip to content

Commit ae55e0f

Browse files
authored
Merge branch 'main' into main
2 parents e520a96 + 91f7584 commit ae55e0f

9 files changed

Lines changed: 234 additions & 789 deletions

Xcodes/Frontend/Common/NavigationSplitViewWrapper.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,20 @@ struct NavigationSplitViewWrapper<Sidebar, Detail>: View where Sidebar: View, De
2626

2727
if #available(macOS 14, *) {
2828
sidebar
29-
.toolbar(removing: .sidebarToggle)
29+
.navigationSplitViewColumnWidth(min: 250, ideal: 300)
3030
} else {
3131
sidebar
3232
}
3333
} detail: {
3434
detail
3535
}
36+
.navigationSplitViewStyle(.balanced)
3637
} else {
3738
// Alternative code for earlier versions of OS.
3839
NavigationView {
3940
// The first column is the sidebar.
4041
sidebar
42+
.frame(minWidth: 250)
4143
detail
4244
}
4345
.navigationViewStyle(.columns)

Xcodes/Frontend/InfoPane/CornerRadiusModifier.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ extension View {
2929
struct Previews_CornerRadius_Previews: PreviewProvider {
3030
static var previews: some View {
3131
HStack {
32-
Text("XCODES RULES!")
32+
Text(verbatim: "XCODES RULES!")
3333
}.xcodesBackground()
3434
}
3535
}

Xcodes/Frontend/InfoPane/IdenticalBuildView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ struct IdenticalBuildsView: View {
2929
.font(.headline)
3030

3131
ForEach(builds, id: \.description) { version in
32-
Text("\(version.appleDescription)")
32+
Text(verbatim: "\(version.appleDescription)")
3333
.font(.subheadline)
3434
}
3535
}

Xcodes/Frontend/MainWindow.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ struct MainWindow: View {
2020
var body: some View {
2121
NavigationSplitViewWrapper {
2222
XcodeListView(selectedXcodeID: $selectedXcodeID, searchText: searchText, category: category, isInstalledOnly: isInstalledOnly)
23-
.frame(minWidth: 260)
2423
.layoutPriority(1)
2524
.alert(item: $appState.xcodeBeingConfirmedForUninstallation) { xcode in
2625
Alert(title: Text(String(format: localizeString("Alert.Uninstall.Title"), xcode.description)),

Xcodes/Frontend/Preferences/AdvancedPreferencePane.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,14 @@ struct AdvancedPreferencePane: View {
8080

8181
GroupBox(label: Text("Active/Select")) {
8282
VStack(alignment: .leading) {
83-
Picker("OnSelect", selection: $appState.onSelectActionType) {
83+
Picker(selection: $appState.onSelectActionType) {
8484

8585
Text(SelectedActionType.none.description)
8686
.tag(SelectedActionType.none)
8787
Text(SelectedActionType.rename.description)
8888
.tag(SelectedActionType.rename)
89+
} label: {
90+
Text(verbatim: "OnSelect")
8991
}
9092
.labelsHidden()
9193
.pickerStyle(.inline)

Xcodes/Frontend/SignIn/SignInCredentialsView.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ struct SignInCredentialsView: View {
1313
HStack {
1414
Text("AppleID")
1515
.frame(minWidth: 100, alignment: .trailing)
16-
TextField("example@icloud.com", text: $username)
16+
TextField(text: $username) {
17+
Text(verbatim: "example@icloud.com")
18+
}
1719
}
1820
HStack {
1921
Text("Password")

Xcodes/Frontend/View+IsHidden.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ extension View {
1414
struct View_IsHidden_Previews: PreviewProvider {
1515
static var previews: some View {
1616
Group {
17-
Text("Not Hidden")
17+
Text(verbatim: "Not Hidden")
1818
.isHidden(false)
1919

20-
Text("Hidden")
20+
Text(verbatim: "Hidden")
2121
.isHidden(true)
2222
}
2323
}

Xcodes/Frontend/XcodeList/AppStoreButtonStyle.swift

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,33 +97,45 @@ struct AppStoreButtonStyle_Previews: PreviewProvider {
9797
Group {
9898
ForEach([ColorScheme.light, .dark], id: \.self) { colorScheme in
9999
Group {
100-
Button("OPEN", action: {})
100+
Button{ } label: {
101+
Text(verbatim: "OPEN")
102+
}
101103
.buttonStyle(AppStoreButtonStyle(primary: true, highlighted: false))
102104
.padding()
103105
.background(Color(.textBackgroundColor))
104106
.previewDisplayName("Primary")
105-
Button("OPEN", action: {})
107+
Button{ } label: {
108+
Text(verbatim: "OPEN")
109+
}
106110
.buttonStyle(AppStoreButtonStyle(primary: true, highlighted: true))
107111
.padding()
108112
.background(Color(.controlAccentColor))
109113
.previewDisplayName("Primary, Highlighted")
110-
Button("OPEN", action: {})
114+
Button{ } label: {
115+
Text(verbatim: "OPEN")
116+
}
111117
.buttonStyle(AppStoreButtonStyle(primary: true, highlighted: false))
112118
.padding()
113119
.disabled(true)
114120
.background(Color(.textBackgroundColor))
115121
.previewDisplayName("Primary, Disabled")
116-
Button("INSTALL", action: {})
122+
Button{ } label: {
123+
Text(verbatim: "INSTALL")
124+
}
117125
.buttonStyle(AppStoreButtonStyle(primary: false, highlighted: false))
118126
.padding()
119127
.background(Color(.textBackgroundColor))
120128
.previewDisplayName("Secondary")
121-
Button("INSTALL", action: {})
129+
Button{ } label: {
130+
Text(verbatim: "INSTALL")
131+
}
122132
.buttonStyle(AppStoreButtonStyle(primary: false, highlighted: true))
123133
.padding()
124134
.background(Color(.controlAccentColor))
125135
.previewDisplayName("Secondary, Highlighted")
126-
Button("INSTALL", action: {})
136+
Button{ } label: {
137+
Text(verbatim: "INSTALL")
138+
}
127139
.buttonStyle(AppStoreButtonStyle(primary: false, highlighted: false))
128140
.padding()
129141
.disabled(true)

0 commit comments

Comments
 (0)