From 68eadc52eec92b172d34b38d111098bbb3879d62 Mon Sep 17 00:00:00 2001
From: Abhishek Kudwa <ashu.kudwa@gmail.com>
Date: Sun, 4 Oct 2026 20:17:04 +0000
Subject: [PATCH] build: add checkstyle reporter

---
 .../interceptors/auth/AuthInterceptor.java    |  1 -
 .../sdk/client/http/JdkA2AHttpClientTest.java |  1 -
 .../common/json/TaskSerializationTest.java    |  1 -
 pom.xml                                       | 33 +++++++++++++++++++
 .../AuthorizationCodeOAuthFlowMapper.java     |  1 -
 .../sdk/grpc/utils/JSONRPCUtilsTest.java      |  1 -
 .../a2aproject/sdk/spec/ListTasksParams.java  |  1 -
 src/checkstyle/checkstyle.xml                 | 21 ++++++++++++
 8 files changed, 54 insertions(+), 6 deletions(-)
 create mode 100644 src/checkstyle/checkstyle.xml

diff --git a/client/transport/spi/src/main/java/org/a2aproject/sdk/client/transport/spi/interceptors/auth/AuthInterceptor.java b/client/transport/spi/src/main/java/org/a2aproject/sdk/client/transport/spi/interceptors/auth/AuthInterceptor.java
index 1854eb497..2bb1272a2 100644
--- a/client/transport/spi/src/main/java/org/a2aproject/sdk/client/transport/spi/interceptors/auth/AuthInterceptor.java
+++ b/client/transport/spi/src/main/java/org/a2aproject/sdk/client/transport/spi/interceptors/auth/AuthInterceptor.java
@@ -1,7 +1,6 @@
 package org.a2aproject.sdk.client.transport.spi.interceptors.auth;
 
 import java.util.HashMap;
-import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
diff --git a/http-client/src/test/java/org/a2aproject/sdk/client/http/JdkA2AHttpClientTest.java b/http-client/src/test/java/org/a2aproject/sdk/client/http/JdkA2AHttpClientTest.java
index c99490408..dff52b5c3 100644
--- a/http-client/src/test/java/org/a2aproject/sdk/client/http/JdkA2AHttpClientTest.java
+++ b/http-client/src/test/java/org/a2aproject/sdk/client/http/JdkA2AHttpClientTest.java
@@ -1,7 +1,6 @@
 package org.a2aproject.sdk.client.http;
 
 import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockserver.integration.ClientAndServer;
 
diff --git a/jsonrpc-common/src/test/java/org/a2aproject/sdk/jsonrpc/common/json/TaskSerializationTest.java b/jsonrpc-common/src/test/java/org/a2aproject/sdk/jsonrpc/common/json/TaskSerializationTest.java
index 73fdb58c1..05110a9c1 100644
--- a/jsonrpc-common/src/test/java/org/a2aproject/sdk/jsonrpc/common/json/TaskSerializationTest.java
+++ b/jsonrpc-common/src/test/java/org/a2aproject/sdk/jsonrpc/common/json/TaskSerializationTest.java
@@ -7,7 +7,6 @@
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.time.OffsetDateTime;
diff --git a/pom.xml b/pom.xml
index 34af82a92..94408fd33 100644
--- a/pom.xml
+++ b/pom.xml
@@ -48,6 +48,9 @@
         <maven-surefire-plugin.version>3.5.6</maven-surefire-plugin.version>
         <maven-javadoc-plugin.version>3.12.0</maven-javadoc-plugin.version>
         <maven-gpg-plugin.version>3.2.8</maven-gpg-plugin.version>
+        <maven-checkstyle-plugin.version>3.5.0</maven-checkstyle-plugin.version>
+        <checkstyle.failOnViolation>false</checkstyle.failOnViolation>
+        <checkstyle.version>9.3</checkstyle.version>
         <gmavenplus-plugin.version>5.1.0</gmavenplus-plugin.version>
         <sonatype-central-publishing-plugin.version>0.11.0</sonatype-central-publishing-plugin.version>
         <groovy.version>5.1.2</groovy.version>
@@ -591,6 +594,36 @@
                 <groupId>org.sonatype.central</groupId>
                 <artifactId>central-publishing-maven-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>${maven-checkstyle-plugin.version}</version>
+                <dependencies>
+                    <dependency>
+                        <groupId>com.puppycrawl.tools</groupId>
+                        <artifactId>checkstyle</artifactId>
+                        <version>${checkstyle.version}</version>
+                    </dependency>
+                </dependencies>
+                <executions>
+                    <execution>
+                        <id>checkstyle-validation</id>
+                        <phase>validate</phase>
+                        <inherited>true</inherited>
+                        <configuration>
+                            <skip>false</skip>
+                            <configLocation>src/checkstyle/checkstyle.xml</configLocation>
+                            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                            <consoleOutput>true</consoleOutput>
+                            <failsOnError>false</failsOnError>
+                            <failOnViolation>${checkstyle.failOnViolation}</failOnViolation>
+                        </configuration>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
 
diff --git a/spec-grpc/src/main/java/org/a2aproject/sdk/grpc/mapper/AuthorizationCodeOAuthFlowMapper.java b/spec-grpc/src/main/java/org/a2aproject/sdk/grpc/mapper/AuthorizationCodeOAuthFlowMapper.java
index 2ab04ba8e..785822f26 100644
--- a/spec-grpc/src/main/java/org/a2aproject/sdk/grpc/mapper/AuthorizationCodeOAuthFlowMapper.java
+++ b/spec-grpc/src/main/java/org/a2aproject/sdk/grpc/mapper/AuthorizationCodeOAuthFlowMapper.java
@@ -2,7 +2,6 @@
 
 import org.mapstruct.CollectionMappingStrategy;
 import org.mapstruct.Mapper;
-import org.mapstruct.Mapping;
 
 /**
  * Mapper between {@link org.a2aproject.sdk.spec.AuthorizationCodeOAuthFlow} and {@link org.a2aproject.sdk.grpc.AuthorizationCodeOAuthFlow}.
diff --git a/spec-grpc/src/test/java/org/a2aproject/sdk/grpc/utils/JSONRPCUtilsTest.java b/spec-grpc/src/test/java/org/a2aproject/sdk/grpc/utils/JSONRPCUtilsTest.java
index c072c1df9..063792da5 100644
--- a/spec-grpc/src/test/java/org/a2aproject/sdk/grpc/utils/JSONRPCUtilsTest.java
+++ b/spec-grpc/src/test/java/org/a2aproject/sdk/grpc/utils/JSONRPCUtilsTest.java
@@ -34,7 +34,6 @@
 import org.a2aproject.sdk.jsonrpc.common.wrappers.GetTaskResponse;
 import org.a2aproject.sdk.jsonrpc.common.wrappers.SendMessageRequest;
 import org.a2aproject.sdk.spec.DataPart;
-import org.a2aproject.sdk.spec.GetExtendedAgentCardParams;
 import org.a2aproject.sdk.spec.InvalidParamsError;
 import org.a2aproject.sdk.spec.JSONParseError;
 import org.a2aproject.sdk.spec.Message;
diff --git a/spec/src/main/java/org/a2aproject/sdk/spec/ListTasksParams.java b/spec/src/main/java/org/a2aproject/sdk/spec/ListTasksParams.java
index e2d5acf63..9cb64bb37 100644
--- a/spec/src/main/java/org/a2aproject/sdk/spec/ListTasksParams.java
+++ b/spec/src/main/java/org/a2aproject/sdk/spec/ListTasksParams.java
@@ -1,6 +1,5 @@
 package org.a2aproject.sdk.spec;
 
-import org.a2aproject.sdk.util.Assert;
 import java.time.Instant;
 
 import org.a2aproject.sdk.spec.util.Utils;
diff --git a/src/checkstyle/checkstyle.xml b/src/checkstyle/checkstyle.xml
new file mode 100644
index 000000000..5c5f662db
--- /dev/null
+++ b/src/checkstyle/checkstyle.xml
@@ -0,0 +1,21 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+    "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+    "https://checkstyle.org/dtds/configuration_1_3.dtd">
+
+<module name="Checker">
+
+    <module name="TreeWalker">
+
+        <!-- Report trailing whitespace. -->
+        <module name="RegexpSinglelineJava">
+            <property name="format" value="[ \t]+$"/>
+            <property name="message" value="Line has trailing whitespace."/>
+        </module>
+
+        <!-- Report imports that are not used. -->
+        <module name="UnusedImports"/>
+
+    </module>
+
+</module>