Drop EOL versions, switch to Cuprite, modernize CI

- Require Ruby >= 3.1, Rails >= 7.1, ActiveAdmin >= 3.0
- Replace chromedriver-helper with Cuprite
- Replace Travis CI with GitHub Actions
- Add ransackable_attributes for Ransack 4+
- Fix Rails 7.1 config/environment.rb template

Author: Fivell

.github/workflows/ci.yml

@@ -0,0 +1,26 @@
+name: CI
+on:
+  pull_request:
+  push:
+    branches: [master]
+jobs:
+  test:
+    name: Ruby ${{ matrix.ruby }} / Rails ${{ matrix.rails }} / AA ${{ matrix.activeadmin }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ['3.2.0', '3.3.0', '3.4.0']
+        rails: ['7.1.0', '7.2.0']
+        activeadmin: ['3.2.0', '3.3.0']
+    env:
+      RAILS: ${{ matrix.rails }}
+      AA: ${{ matrix.activeadmin }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Run tests
+        run: bundle exec rspec spec

.gitignore

@@ -0,0 +1,5 @@
+/.bundle/
+/Gemfile.lock
+/pkg/
+/tmp/
+spec/rails/rails-*

.travis.yml

@@ -1,18 +1,19 @@
 source 'https://rubygems.org'
-
-# Specify your gem's dependencies in activeadmin_scoped_collection_actions.gemspec
 gemspec
 
-group :test do
-  gem 'rails', "~> #{ENV['RAILS'] || '5.2.1'}"
-  gem 'activeadmin', "~> #{ENV['AA'] || '1.3.1'}"
+default_rails_version = '7.1.0'
+default_activeadmin_version = '3.2.0'
 
+gem 'rails', "~> #{ENV['RAILS'] || default_rails_version}"
+gem 'activeadmin', "~> #{ENV['AA'] || default_activeadmin_version}"
+gem 'sprockets-rails'
+gem 'sass-rails'
+
+group :test do
   gem 'rspec-rails'
-  gem 'sqlite3'
+  gem 'sqlite3', '~> 2.0'
   gem 'database_cleaner'
   gem 'capybara'
-  gem 'selenium-webdriver'
-  gem 'chromedriver-helper'
-  gem 'byebug'
-  gem 'sassc-rails'
+  gem 'cuprite'
+  gem 'webrick', require: false
 end

Gemfile

@@ -2,6 +2,4 @@ require "bundler"
 require 'rake'
 Bundler.setup
 Bundler::GemHelper.install_tasks
-
-# Import all our rake tasks
 FileList['tasks/**/*.rake'].each { |task| import task }

Rakefile

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 $:.push File.expand_path("../lib", __FILE__)
 require "active_admin_sidebar/version"
 
@@ -7,15 +6,17 @@ Gem::Specification.new do |s|
   s.version     = ActiveAdminSidebar::VERSION
   s.authors     = ["Igor"]
   s.email       = ["fedoronchuk@gmail.com"]
-  s.homepage    = "https://github.com/Fivell/active_admin_sidebar"
+  s.homepage    = "https://github.com/activeadmin-plugins/active_admin_sidebar"
   s.summary     = %q{active_admin_sidebar gem}
   s.description = %q{extension for activeadmin gem to manage sidebar}
+  s.license     = "MIT"
 
-  s.add_dependency "activeadmin"
+  s.required_ruby_version = '>= 3.1.0'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
+  s.add_dependency "activeadmin", ">= 3.0", "< 4.0"
 end

active_admin_sidebar.gemspec

@@ -6,28 +6,23 @@
 Bundler.setup
 
 ENV['RAILS_ENV'] = 'test'
-# Ensure the Active Admin load path is happy
 require 'rails'
 ENV['RAILS'] = Rails.version
 ENV['RAILS_ROOT'] = File.expand_path("../rails/rails-#{ENV['RAILS']}", __FILE__)
-# Create the test app if it doesn't exists
-unless File.exists?(ENV['RAILS_ROOT'])
+unless File.exist?(ENV['RAILS_ROOT'])
   system 'rake setup'
 end
 
 require 'rails/all'
 require 'active_admin'
 ActiveAdmin.application.load_paths = [ENV['RAILS_ROOT'] + "/app/admin"]
 require ENV['RAILS_ROOT'] + '/config/environment.rb'
-# Disabling authentication in specs so that we don't have to worry about
-# it allover the place
 ActiveAdmin.application.authentication_method = false
 ActiveAdmin.application.current_user_method = false
 
 require 'rspec/rails'
 require 'capybara/rails'
 require 'capybara/rspec'
-require 'selenium-webdriver'
 
 require 'support/admin'
 require 'support/capybara'
@@ -36,6 +31,7 @@
   config.use_transactional_fixtures = false
 
   config.before(:suite) do
+    ActiveRecord::Migration.maintain_test_schema!
     DatabaseCleaner.strategy = :truncation
     DatabaseCleaner.clean_with(:truncation)
   end
@@ -46,5 +42,4 @@
   config.after(:each) do
     DatabaseCleaner.clean
   end
-
 end

spec/spec_helper.rb

@@ -1,13 +1,8 @@
-Capybara.configure do |config|
-  config.match = :prefer_exact
-end
-
-Capybara.register_driver :selenium_chrome do |app|
-  options = Selenium::WebDriver::Chrome::Options.new(
-    args: %w[headless disable-gpu no-sandbox]
-  )
-  Capybara::Selenium::Driver.new(app, browser: :chrome, options: options)
-end
+require 'capybara/cuprite'
 
 Capybara.server = :webrick
-Capybara.javascript_driver = :selenium_chrome
+Capybara.register_driver :cuprite do |app|
+  Capybara::Cuprite::Driver.new(app, headless: true, window_size: [1280, 800])
+end
+Capybara.javascript_driver = :cuprite
+Capybara.default_max_wait_time = 5

spec/support/capybara.rb

@@ -1,21 +1,29 @@
-# Rails template to build the sample app for specs
+generate :model, 'author name:string{10}:uniq last_name:string birthday:date --force'
+generate :model, 'post title:string:uniq body:text author:references --force'
 
-generate :model, 'author name:string{10}:uniq last_name:string birthday:date'
-generate :model, 'post title:string:uniq body:text author:references'
-
-#Add validation
-inject_into_file "app/models/author.rb", "  validates_presence_of :name\n  validates_uniqueness_of :last_name\n", after: "Base\n"
+inject_into_file "app/models/author.rb", "  validates_presence_of :name\n  validates_uniqueness_of :last_name\n", after: "ApplicationRecord\n"
 inject_into_file "app/models/post.rb", "   validates_presence_of :author\n", after: ":author\n"
 
-# Configure default_url_options in test environment
-inject_into_file "config/environments/test.rb", "  config.action_mailer.default_url_options = { :host => 'example.com' }\n", after: "config.cache_classes = true\n"
-
-# Add our local Active Admin to the load path
-inject_into_file "config/environment.rb",
-                 "\n$LOAD_PATH.unshift('#{File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib'))}')\nrequire \"active_admin\"\n",
-                 after: "require File.expand_path('../application', __FILE__)"
-
-run "rm Gemfile"
+# Add ransackable_attributes for Ransack 4+
+inject_into_file "app/models/author.rb",
+  "  def self.ransackable_attributes(auth_object = nil)\n" \
+  "    [\"name\", \"last_name\", \"birthday\", \"created_at\", \"updated_at\"]\n" \
+  "  end\n",
+  after: "ApplicationRecord\n"
+
+inject_into_file "app/models/post.rb",
+  "  def self.ransackable_attributes(auth_object = nil)\n" \
+  "    [\"title\", \"body\", \"author_id\"]\n" \
+  "  end\n" \
+  "  def self.ransackable_associations(auth_object = nil)\n" \
+  "    [\"author\"]\n" \
+  "  end\n",
+  after: "ApplicationRecord\n"
+
+# Add our local Active Admin to the load path (Rails 7.1+)
+gsub_file "config/environment.rb",
+  'require_relative "application"',
+  "require_relative \"application\"\n$LOAD_PATH.unshift('#{File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib'))}')\nrequire \"active_admin\"\n"
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 
@@ -31,19 +39,12 @@
                  "@import \"active_admin_sidebar\";\n",
                  after: "@import \"active_admin/base\";\n"
 
-if File.file?("app/assets/javascripts/active_admin.js")
-  inject_into_file "app/assets/javascripts/active_admin.js",
-    "//= require active_admin_sidebar\n",
-    after: "//= require active_admin/base\n"
-else
-  inject_into_file "app/assets/javascripts/active_admin.js.coffee",
-    "#= require active_admin_sidebar\n",
-    after: "#= require active_admin/base\n"
-end
-
-run "rm -r test"
-run "rm -r spec"
+inject_into_file "app/assets/javascripts/active_admin.js",
+  "//= require active_admin_sidebar\n",
+  after: "//= require active_admin/base\n"
 
+run "rm -rf test"
 route "root :to => 'admin/dashboard#index'"
-
 rake "db:migrate"
+
+run "rm -f Gemfile Gemfile.lock"

spec/support/rails_template.rb

@@ -1,13 +1,11 @@
 desc "Creates a test rails app for the specs to run against"
 task :setup do
   require 'rails/version'
-  system("mkdir spec/rails") unless File.exists?("spec/rails")
 
   rails_new_opts = %w(
     --skip-turbolinks
     --skip-spring
     --skip-bootsnap
-    --skip-webpack-install
     -m
     spec/support/rails_template.rb
   )