Use ffi.buffer to better handle nulls

Author: bbayles

ada_url/ada_adapter.py

@@ -116,8 +116,7 @@ def _get_obj(constructor, destructor, *args):
 
 
 def _get_str(x):
-    ret = ffi.string(x.data, x.length).decode() if x.length else ''
-    return ret
+    return bytes(ffi.buffer(x.data, x.length)).decode() if x.length else ''
 
 
 class URL:

tests/test_ada_url.py

@@ -531,6 +531,13 @@ def test_replace_search_params(self):
         expected = 'key2=value3&key1=value4&key1=value5'
         self.assertEqual(actual, expected)
 
+    def test_null_handling(self):
+        evil_input = 'admin\x00hidden=true&safe=value'
+        params = SearchParams(evil_input)
+        actual = list(params.keys())
+        expected = ['admin\x00hidden', 'safe']
+        self.assertEqual(actual, expected)
+
 
 class ParseTests(TestCase):
     def test_url_suite(self):