Skip to content

Commit cb7a8cb

Browse files
authored
Version 1.30.0: ada 3.4.4, add wheels for 3.14
* Upgrade cibuildwheel to 3.3.1 * Drop pp310 wheels * Upgrade to ada 3.4.3 * Bump to version 1.30.0
1 parent b155ccf commit cb7a8cb

4 files changed

Lines changed: 24 additions & 17 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
uses: docker/setup-qemu-action@v3
4040
with:
4141
platforms: all
42-
- uses: pypa/cibuildwheel@v2.22.0
42+
- uses: pypa/cibuildwheel@v3.3.1
4343
- uses: actions/upload-artifact@v4
4444
with:
4545
name: artifact-wheel-${{ matrix.os }}

ada_url/ada.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* auto-generated on 2026-01-30 13:29:04 -0500. Do not edit! */
1+
/* auto-generated on 2026-02-23 21:29:24 -0500. Do not edit! */
22
/* begin file src/ada.cpp */
33
#include "ada.h"
44
/* begin file src/checkers.cpp */
@@ -14495,6 +14495,12 @@ bool url_aggregator::set_pathname(const std::string_view input) {
1449514495
if (get_pathname().starts_with("//") && !has_authority() && !has_dash_dot()) {
1449614496
buffer.insert(components.pathname_start, "/.");
1449714497
components.pathname_start += 2;
14498+
if (components.search_start != url_components::omitted) {
14499+
components.search_start += 2;
14500+
}
14501+
if (components.hash_start != url_components::omitted) {
14502+
components.hash_start += 2;
14503+
}
1449814504
}
1449914505
ADA_ASSERT_TRUE(validate());
1450014506
return true;

ada_url/ada.h

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* auto-generated on 2026-01-30 13:29:04 -0500. Do not edit! */
1+
/* auto-generated on 2026-02-23 21:29:24 -0500. Do not edit! */
22
/* begin file include/ada.h */
33
/**
44
* @file ada.h
@@ -8091,6 +8091,12 @@ inline void url_aggregator::update_base_pathname(const std::string_view input) {
80918091
// output.
80928092
buffer.insert(components.pathname_start, "/.");
80938093
components.pathname_start += 2;
8094+
if (components.search_start != url_components::omitted) {
8095+
components.search_start += 2;
8096+
}
8097+
if (components.hash_start != url_components::omitted) {
8098+
components.hash_start += 2;
8099+
}
80948100
}
80958101

80968102
uint32_t difference = replace_and_resize(
@@ -9530,13 +9536,14 @@ url_pattern_component<regex_provider>::create_component_match_result(
95309536
auto result =
95319537
url_pattern_component_result{.input = std::move(input), .groups = {}};
95329538

9533-
// Optimization: Let's reserve the size.
9534-
result.groups.reserve(exec_result.size());
9535-
95369539
// We explicitly start iterating from 0 even though the spec
95379540
// says we should start from 1. This case is handled by the
9538-
// std_regex_provider.
9539-
for (size_t index = 0; index < exec_result.size(); index++) {
9541+
// std_regex_provider which removes the full match from index 0.
9542+
// Use min() to guard against potential mismatches between
9543+
// exec_result size and group_name_list size.
9544+
const size_t size = std::min(exec_result.size(), group_name_list.size());
9545+
result.groups.reserve(size);
9546+
for (size_t index = 0; index < size; index++) {
95409547
result.groups.emplace(group_name_list[index],
95419548
std::move(exec_result[index]));
95429549
}
@@ -11221,14 +11228,14 @@ constructor_string_parser<regex_provider>::parse(std::string_view input) {
1122111228
#ifndef ADA_ADA_VERSION_H
1122211229
#define ADA_ADA_VERSION_H
1122311230

11224-
#define ADA_VERSION "3.4.2"
11231+
#define ADA_VERSION "3.4.3"
1122511232

1122611233
namespace ada {
1122711234

1122811235
enum {
1122911236
ADA_VERSION_MAJOR = 3,
1123011237
ADA_VERSION_MINOR = 4,
11231-
ADA_VERSION_REVISION = 2,
11238+
ADA_VERSION_REVISION = 3,
1123211239
};
1123311240

1123411241
} // namespace ada

pyproject.toml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
44

55
[project]
66
name = "ada-url"
7-
version = "1.29.0"
7+
version = "1.30.0"
88
authors = [
99
{name = "Bo Bayles", email = "bo@bbayles.com"},
1010
]
@@ -61,7 +61,6 @@ build = [
6161
"cp312-*",
6262
"cp313-*",
6363
"cp314-*",
64-
"pp310-*",
6564
]
6665
manylinux-x86_64-image = "manylinux_2_28"
6766
manylinux-aarch64-image = "manylinux_2_28"
@@ -76,8 +75,3 @@ before-build = "make clean"
7675

7776
[tool.cibuildwheel.windows]
7877
archs = ["AMD64"]
79-
80-
# https://github.com/pypy/pypy/issues/5027
81-
[[tool.cibuildwheel.overrides]]
82-
select = "pp310-win_amd64"
83-
environment = { SETUPTOOLS_USE_DISTUTILS="stdlib" }

0 commit comments

Comments
 (0)