fix(@angular/cli): batch Prettier invocations during migration formatting

`formatFiles` passed every changed file to Prettier as a single `execFile`
argument list. On large repositories (thousands of changed files) the combined
command line exceeds the OS limit and the spawn is rejected with `spawn E2BIG`
(POSIX) or `spawn ENAMETOOLONG` (Windows). The error is caught and only logged,
so `ng update` migrations print `WARNING: Formatting of files failed ...` and
silently skip formatting on exactly the large repos the step targets.

Split the file list into batches that stay under a conservative command-line
length budget and invoke Prettier once per batch.

Fixes #33597

Author: mdlufy

packages/angular/cli/src/utilities/prettier.ts

@@ -15,6 +15,50 @@ import { promisify } from 'node:util';
 const execFileAsync = promisify(execFile);
 let prettierCliPath: string | null | undefined;
 
+/**
+ * Conservative upper bound for the length of a single spawned command line.
+ * Windows caps `CreateProcess` command lines at 32,767 characters; POSIX `ARG_MAX`
+ * is larger. Staying below this budget avoids `E2BIG`/`ENAMETOOLONG` when a large
+ * migration changes thousands of files.
+ */
+const MAX_COMMAND_LINE_LENGTH = 32_000;
+
+/**
+ * Groups files into batches whose combined argument length (including `baseLength`
+ * for the fixed leading arguments) stays under `maxLength`. A file longer on its own
+ * than the budget still gets its own batch, so files are never dropped.
+ */
+export function batchFilesByArgumentLength(
+  files: Iterable<string>,
+  baseLength: number,
+  maxLength: number,
+): string[][] {
+  const batches: string[][] = [];
+  let batch: string[] = [];
+  let length = baseLength;
+
+  for (const file of files) {
+    // Account for the separator between arguments, plus the surrounding quotes the OS
+    // adds to paths containing spaces when they are spawned.
+    const fileLength = file.length + (file.includes(' ') ? 3 : 1);
+
+    if (batch.length > 0 && length + fileLength > maxLength) {
+      batches.push(batch);
+      batch = [];
+      length = baseLength;
+    }
+
+    batch.push(file);
+    length += fileLength;
+  }
+
+  if (batch.length > 0) {
+    batches.push(batch);
+  }
+
+  return batches;
+}
+
 /**
  * Formats files using Prettier.
  * @param cwd The current working directory.
@@ -42,12 +86,26 @@ export async function formatFiles(cwd: string, files: Set<string>): Promise<void
     return;
   }
 
-  await execFileAsync(
-    process.execPath,
-    [prettierCliPath, '--write', '--no-error-on-unmatched-pattern', '--ignore-unknown', ...files],
-    {
+  const baseArgs = [
+    prettierCliPath,
+    '--write',
+    '--no-error-on-unmatched-pattern',
+    '--ignore-unknown',
+  ];
+  // `process.execPath` is spawned as the first argument and also counts toward the
+  // command-line limit; it and `prettierCliPath` are absolute paths that may contain
+  // spaces and therefore be quoted.
+  const baseLength = [process.execPath, ...baseArgs].reduce(
+    (total, arg) => total + arg.length + (arg.includes(' ') ? 3 : 1),
+    0,
+  );
+
+  // Spawn Prettier once per batch so repositories with many changed files do not
+  // overflow the OS command-line length limit.
+  for (const batch of batchFilesByArgumentLength(files, baseLength, MAX_COMMAND_LINE_LENGTH)) {
+    await execFileAsync(process.execPath, [...baseArgs, ...batch], {
       cwd,
       shell: false,
-    },
-  );
+    });
+  }
 }

packages/angular/cli/src/utilities/prettier_spec.ts

@@ -0,0 +1,67 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
+import { batchFilesByArgumentLength } from './prettier';
+
+describe('batchFilesByArgumentLength', () => {
+  it('returns no batches when there are no files', () => {
+    expect(batchFilesByArgumentLength([], 10, 100)).toEqual([]);
+  });
+
+  it('keeps files that fit the budget in a single batch', () => {
+    const files = ['a.ts', 'b.ts', 'c.ts'];
+
+    expect(batchFilesByArgumentLength(files, 0, 1000)).toEqual([files]);
+  });
+
+  it('splits files into multiple batches when the budget is exceeded', () => {
+    // Each file contributes `length + 1` => 5; a budget of 12 fits two files per batch.
+    expect(batchFilesByArgumentLength(['aaaa', 'bbbb', 'cccc', 'dddd'], 0, 12)).toEqual([
+      ['aaaa', 'bbbb'],
+      ['cccc', 'dddd'],
+    ]);
+  });
+
+  it('reserves the base argument length in every batch', () => {
+    // base 8, each file => 5: 8 + 5 fits, 8 + 5 + 5 > 15 so the second file starts a new batch.
+    expect(batchFilesByArgumentLength(['aaaa', 'bbbb'], 8, 15)).toEqual([['aaaa'], ['bbbb']]);
+  });
+
+  it('reserves extra length for files that contain spaces (quoted when spawned)', () => {
+    // 'a a' contains a space => length + 3 = 6; the others => length + 1 = 2. Budget 10:
+    // 6 + 2 + 2 fits, adding the fourth file (12) exceeds it.
+    expect(batchFilesByArgumentLength(['a a', 'b', 'c', 'd'], 0, 10)).toEqual([
+      ['a a', 'b', 'c'],
+      ['d'],
+    ]);
+  });
+
+  it('never drops a file that is longer than the budget on its own', () => {
+    const files = ['short', 'a-very-long-single-file-name-well-over-budget', 'tiny'];
+
+    const batches = batchFilesByArgumentLength(files, 0, 10);
+
+    expect(batches.flat()).toEqual(files);
+    expect(batches).toContain(['a-very-long-single-file-name-well-over-budget']);
+  });
+
+  it('keeps multi-file batches within the budget for a large file set', () => {
+    const files = Array.from({ length: 5000 }, (_, index) => `path/to/file-${index}.component.ts`);
+    const baseLength = 40;
+    const maxLength = 2000;
+
+    for (const batch of batchFilesByArgumentLength(files, baseLength, maxLength)) {
+      const length = batch.reduce((total, file) => total + file.length + 1, baseLength);
+
+      // A batch may exceed the budget only when it is a single unavoidable oversized file.
+      if (batch.length > 1) {
+        expect(length).toBeLessThanOrEqual(maxLength);
+      }
+    }
+  });
+});