Skip to content

Commit 963b4ba

Browse files
committed
refactor(aria/menu): move item patterns into computed signal instead of afterRenderEffect
1 parent 046e1a2 commit 963b4ba

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

src/aria/menu/menu-bar.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export class MenuBar<V> {
104104
readonly _pattern: MenuBarPattern<V>;
105105

106106
/** The menu items as a writable signal. */
107-
private readonly _itemPatterns = signal<any[]>([]);
107+
private readonly _itemPatterns = computed(() => this._items().map(i => i._pattern));
108108

109109
/** A callback function triggered when a menu item is selected. */
110110
readonly itemSelected = output<V>();
@@ -123,10 +123,6 @@ export class MenuBar<V> {
123123
element: computed(() => this._elementRef.nativeElement),
124124
});
125125

126-
afterRenderEffect(() => {
127-
this._itemPatterns.set(this._items().map(i => i._pattern));
128-
});
129-
130126
afterRenderEffect(() => {
131127
this._pattern.setDefaultStateEffect();
132128
});

0 commit comments

Comments
 (0)