Repository navigation
Commit 0868f39
Widen the with_extensions annotation to both hooks
`with_extensions` accepts a bundle implementing either hook — the runtime check
tests against both protocols, `test_with_extensions_accepts_a_planner_only_extension`
pins it, and the FFI guide's `PlannerOf` adapter recommends contributing only the
planner half. The annotation named `SessionExtensionExportable` alone, so a type
checker rejected the very shape the guide tells authors to write.
Two doc comments also went stale. `test_with_extensions_no_extensions_keeps_an_installed_planner`
still described phase two running and rebinding an existing planner, which the
no-op guard now skips outright, and `__datafusion_codec_id__` listed a
`_install_extensions` method that never existed under that name.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 7b6193e commit 0868f39
3 files changed
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1435 | 1435 | | |
1436 | 1436 | | |
1437 | 1437 | | |
1438 | | - | |
1439 | | - | |
1440 | | - | |
1441 | | - | |
1442 | | - | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
1443 | 1443 | | |
1444 | 1444 | | |
1445 | 1445 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1812 | 1812 | | |
1813 | 1813 | | |
1814 | 1814 | | |
1815 | | - | |
| 1815 | + | |
1816 | 1816 | | |
1817 | 1817 | | |
1818 | 1818 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
971 | 971 | | |
972 | 972 | | |
973 | 973 | | |
974 | | - | |
975 | | - | |
976 | | - | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
977 | 977 | | |
978 | 978 | | |
979 | 979 | | |
| |||
0 commit comments