Skip to content

Run config_docs CI check is not run on PRs to only change generated docs (resulting in CI failures) #19095

Description

@alamb

Describe the bug

There are several times where we broke CI because we directly changed the .md markdown files that are autogenerated, but the CI in the PR did not run

Here are some recent-ish examples PRs that fixed such issues

To Reproduce

  1. Make a PR with a change to a the docs in docs/source/user-guide/sql/scalar_functions.md
  2. The CI will pass
  3. Commit the PR

However then any PRs that run on code will fail because the autogenerated results will not match what is checked in.

Here is an example of a PR with such a mistake (and I should have known better 🤦 )

Expected behavior

let's fix the docs check to automatically run on PRs that change the auto generated files

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdevelopment-processRelated to development process of DataFusion

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions