From f9e4462cfb6325bf12a3fb0470c271000ce6600f Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Sat, 3 Oct 2026 14:04:55 +0900 Subject: [PATCH 1/2] HBASE-30455 Run website lint in precommit refguide check - Precommit builds the site with -DskipTests, which selects ci-skip-tests - ci-skip-tests skipped lint, so Prettier/ESLint errors only failed the post-merge website job. Follow-up fixes so far: - HBASE-30289 - HBASE-30270 addendum - HBASE-30416 addendum --- hbase-website/README.md | 3 ++- hbase-website/package.json | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hbase-website/README.md b/hbase-website/README.md index 83ea659c3826..f7c532a23318 100644 --- a/hbase-website/README.md +++ b/hbase-website/README.md @@ -421,7 +421,7 @@ If you need the CI flow without unit/e2e test suites, use: npm run ci-skip-tests ``` -This runs extraction, docs initialization, Playwright browser installation, PDF export, and the production build (without lint/typecheck and without unit/e2e test suites). +This runs extraction, docs initialization, lint, Playwright browser installation, PDF export, and the production build (without typecheck and without unit/e2e test suites). Generated files are located under the `build/` directory. @@ -486,6 +486,7 @@ When you run `mvn site`, the website module automatically: - `npm run extract-developers` - Extract developers from parent pom.xml - `npm run extract-hbase-config` - Extract data from `hbase-default.xml` to `app/pages/_docs/docs/_mdx/(multi-page)/configuration/hbase-default.md` - `npm run extract-hbase-version` - Extract version from root `pom.xml` to `app/lib/export-pdf/hbase-version.json` + - `npm run lint` - ESLint code quality checks - `npm run build` - Production build - `npm run generate-sitemap` - Generates `public/sitemap.xml` and `build/client/sitemap.xml` - `npx playwright install` - Installs Playwright browsers diff --git a/hbase-website/package.json b/hbase-website/package.json index 507eba97bfe3..83452136c0a1 100644 --- a/hbase-website/package.json +++ b/hbase-website/package.json @@ -30,7 +30,7 @@ "fumadocs-init": "fumadocs-mdx", "copy-pdf-to-build": "cp -r public/books build/client", "ci": "npm run extract-all && npm run fumadocs-init && npm run lint && npm run typecheck && npm run test:unit:run && npm run build && npm run generate-sitemap && npx playwright install chromium firefox && npm run test:e2e && npm run copy-pdf-to-build", - "ci-skip-tests": "npm run extract-all && npm run fumadocs-init && npm run build && npm run generate-sitemap && npx playwright install chromium && npm run export-pdf && npm run copy-pdf-to-build" + "ci-skip-tests": "npm run extract-all && npm run fumadocs-init && npm run lint && npm run build && npm run generate-sitemap && npx playwright install chromium && npm run export-pdf && npm run copy-pdf-to-build" }, "dependencies": { "@hookform/resolvers": "^3.10.0", From 7a0164f3e5d3d9c3614ee5ac3dbd4082fa6af197 Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Sat, 3 Oct 2026 19:03:49 +0900 Subject: [PATCH 2/2] HBASE-30455 Describe Prettier check in README lint steps --- hbase-website/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hbase-website/README.md b/hbase-website/README.md index f7c532a23318..b5b6c71f6788 100644 --- a/hbase-website/README.md +++ b/hbase-website/README.md @@ -472,7 +472,7 @@ When you run `mvn site`, the website module automatically: - With test skipping (`mvn site -DskipTests`): `npm run ci-skip-tests` `npm run ci` executes: - - `npm run lint` - ESLint code quality checks + - `npm run lint` - ESLint checks and Prettier formatting check for md/mdx files - `npm run typecheck` - TypeScript type checking - `npm run extract-developers` - Extract developers from parent pom.xml - `npm run extract-hbase-config` - Extract data from `hbase-default.xml` to `app/pages/_docs/docs/_mdx/(multi-page)/configuration/hbase-default.md` @@ -486,7 +486,7 @@ When you run `mvn site`, the website module automatically: - `npm run extract-developers` - Extract developers from parent pom.xml - `npm run extract-hbase-config` - Extract data from `hbase-default.xml` to `app/pages/_docs/docs/_mdx/(multi-page)/configuration/hbase-default.md` - `npm run extract-hbase-version` - Extract version from root `pom.xml` to `app/lib/export-pdf/hbase-version.json` - - `npm run lint` - ESLint code quality checks + - `npm run lint` - ESLint checks and Prettier formatting check for md/mdx files - `npm run build` - Production build - `npm run generate-sitemap` - Generates `public/sitemap.xml` and `build/client/sitemap.xml` - `npx playwright install` - Installs Playwright browsers