From f1a60e6b3fe6f24eeb80544cd41e865886490e8e Mon Sep 17 00:00:00 2001 From: Anas Khan <83116240+anxkhn@users.noreply.github.com> Date: Sat, 4 Jul 2026 15:41:54 +0530 Subject: [PATCH] test: fix operator precedence in manifest v2 assertions Six assertions in test_write_manifest and test_write_manifest_list used the form `assert x == a if format_version == 1 else b`. Because a conditional expression binds looser than `==`, Python parses this as `assert (x == a) if (format_version == 1) else b`, so for the format_version == 2 parametrization the whole statement collapses to `assert b`, where b is a truthy constant (3, or ManifestContent.DELETES). The v2 branch therefore always passed and never compared the actual value read back from the manifest. Wrap the right-hand side in parentheses so the conditional expression is the comparison target. This restores verification of the v2 sequence_number, content, min_sequence_number, and file_sequence_number on the manifest read/round-trip path. Test-only change; all parametrized cases (v1 and v2) pass. Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com> --- tests/utils/test_manifest.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/utils/test_manifest.py b/tests/utils/test_manifest.py index f2ae1e05ad..dfe62232a4 100644 --- a/tests/utils/test_manifest.py +++ b/tests/utils/test_manifest.py @@ -424,7 +424,7 @@ def test_write_manifest( assert manifest_entry.status == ManifestEntryStatus.ADDED assert manifest_entry.snapshot_id == 8744736658442914487 - assert manifest_entry.sequence_number == -1 if format_version == 1 else 3 + assert manifest_entry.sequence_number == (-1 if format_version == 1 else 3) assert isinstance(manifest_entry.data_file, DataFile) data_file = manifest_entry.data_file @@ -587,9 +587,9 @@ def test_write_manifest_list( assert manifest_file.manifest_length == 7989 assert manifest_file.partition_spec_id == 0 - assert manifest_file.content == ManifestContent.DATA if format_version == 1 else ManifestContent.DELETES - assert manifest_file.sequence_number == 0 if format_version == 1 else 3 - assert manifest_file.min_sequence_number == 0 if format_version == 1 else 3 + assert manifest_file.content == (ManifestContent.DATA if format_version == 1 else ManifestContent.DELETES) + assert manifest_file.sequence_number == (0 if format_version == 1 else 3) + assert manifest_file.min_sequence_number == (0 if format_version == 1 else 3) assert manifest_file.added_snapshot_id == 9182715666859759686 assert manifest_file.added_files_count == 3 assert manifest_file.existing_files_count == 0 @@ -616,8 +616,8 @@ def test_write_manifest_list( entry = entries[0] - assert entry.sequence_number == 0 if format_version == 1 else 3 - assert entry.file_sequence_number == 0 if format_version == 1 else 3 + assert entry.sequence_number == (0 if format_version == 1 else 3) + assert entry.file_sequence_number == (0 if format_version == 1 else 3) assert entry.snapshot_id == 8744736658442914487 assert entry.status == ManifestEntryStatus.ADDED