dns: nsone: Add API request checking

Author: Aaron Sierra

libcloud/test/dns/test_nsone.py

@@ -35,6 +35,7 @@
 class NsOneTests(unittest.TestCase):
     def setUp(self):
         NsOneMockHttp.type = None
+        NsOneMockHttp.history.clear()
         NsOneDNSDriver.connectionCls.conn_class = NsOneMockHttp
         self.driver = NsOneDNSDriver(*DNS_PARAMS_NSONE)
         self.example_zone = Zone(
@@ -72,6 +73,10 @@ def test_list_zones_empty(self):
     def test_list_zones_success(self):
         zones = self.driver.list_zones()
 
+        sent = NsOneMockHttp.history.pop()
+        self.assertEqual(sent.method, "GET")
+        self.assertEqual(sent.url, "/v1/zones")
+
         self.assertEqual(len(zones), 2)
 
         zone = zones[0]
@@ -100,6 +105,10 @@ def test_delete_zone_success(self):
         NsOneMockHttp.type = "DELETE_ZONE_SUCCESS"
         status = self.driver.delete_zone(zone=self.test_zone)
 
+        sent = NsOneMockHttp.history.pop()
+        self.assertEqual(sent.method, "DELETE")
+        self.assertEqual(sent.url, "/v1/zones/test.com")
+
         self.assertTrue(status)
 
     def test_get_zone_zone_does_not_exist(self):
@@ -115,6 +124,10 @@ def test_get_zone_success(self):
         NsOneMockHttp.type = "GET_ZONE_SUCCESS"
         zone = self.driver.get_zone(zone_id="example.com")
 
+        sent = NsOneMockHttp.history.pop()
+        self.assertEqual(sent.method, "GET")
+        self.assertEqual(sent.url, "/v1/zones/example.com")
+
         self.assertEqual(zone.id, "example.com")
         self.assertEqual(zone.domain, "example.com")
         self.assertIsNone(zone.type),
@@ -124,6 +137,11 @@ def test_create_zone_success(self):
         NsOneMockHttp.type = "CREATE_ZONE_SUCCESS"
         zone = self.driver.create_zone(domain="newzone.com")
 
+        sent = NsOneMockHttp.history.pop()
+        self.assertEqual(sent.method, "PUT")
+        self.assertEqual(sent.url, "/v1/zones/newzone.com")
+        self.assertEqual(sent.json["zone"], "newzone.com")
+
         self.assertEqual(zone.id, "newzone.com")
         self.assertEqual(zone.domain, "newzone.com")
         self.assertIsNone(zone.type),
@@ -153,6 +171,12 @@ def test_get_record_success(self):
         NsOneMockHttp.type = "GET_RECORD_SUCCESS"
         record = self.driver.get_record(zone_id="example.com", record_id="A:www")
 
+        # [0] /v1/zones/example.com
+        # [1] /v1/zones/example.com/www.example.com/A
+        sent = NsOneMockHttp.history.pop()
+        self.assertEqual(sent.method, "GET")
+        self.assertEqual(sent.url, "/v1/zones/example.com/www.example.com/A")
+
         self.assertEqual(record.id, "A:www")
         self.assertEqual(record.name, "www.example.com")
         self.assertEqual(record.data, ["1.1.1.1"])
@@ -177,6 +201,11 @@ def test_list_records_empty(self):
     def test_list_records_success(self):
         NsOneMockHttp.type = "LIST_RECORDS_SUCCESS"
         records = self.driver.list_records(zone=self.example_zone)
+
+        sent = NsOneMockHttp.history.pop()
+        self.assertEqual(sent.method, "GET")
+        self.assertEqual(sent.url, "/v1/zones/example.com")
+
         self.assertEqual(len(records), 2)
 
         arecord = records[1]
@@ -194,6 +223,15 @@ def test_create_record_success(self):
             self.test_record.data,
             self.test_record.extra,
         )
+
+        sent = NsOneMockHttp.history.pop()
+        self.assertEqual(sent.method, "PUT")
+        self.assertEqual(sent.url, "/v1/zones/test.com/test.com/A")
+        self.assertEqual(sent.json["zone"], "test.com")
+        self.assertEqual(sent.json["domain"], "test.com")
+        self.assertEqual(sent.json["type"], "A")
+        self.assertIn({"answer": ["127.0.0.1"]}, sent.json["answers"])
+
         self.assertEqual(arecord.id, "A")
         self.assertEqual(arecord.name, "test.com")
         self.assertEqual(arecord.type, RecordType.A)
@@ -243,11 +281,16 @@ def test_delete_record_success(self):
         NsOneMockHttp.type = "DELETE_RECORD_SUCCESS"
         status = self.driver.delete_record(record=self.test_record)
 
+        sent = NsOneMockHttp.history.pop()
+        self.assertEqual(sent.method, "DELETE")
+        self.assertEqual(sent.url, "/v1/zones/test.com/test.com/A")
+
         self.assertTrue(status)
 
 
 class NsOneMockHttp(MockHttp):
     fixtures = DNSFileFixtures("nsone")
+    keep_history = True
 
     def _v1_zones_EMPTY_ZONES_LIST(self, method, url, body, headers):
         body = self.fixtures.load("empty_zones_list.json")