Fix generator formatting to pass checkstyle

Author: Russole

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/invoker/DeletedBlockLogStateManagerInvoker.java

@@ -143,10 +143,12 @@ public Object invokeLocal(String methodName, Object[] p) throws Exception {
   public Class<?> getReturnType(String methodName, Class<?>[] parameterTypes) {
     switch (methodName) {
     case "addTransactionsToDB":
-      if (Arrays.equals(parameterTypes, new Class<?>[]{ArrayList.class})) {
+      if (Arrays.equals(parameterTypes,
+          new Class<?>[]{ArrayList.class})) {
         return void.class;
       }
-      if (Arrays.equals(parameterTypes, new Class<?>[]{ArrayList.class, DeletedBlocksTransactionSummary.class})) {
+      if (Arrays.equals(parameterTypes,
+          new Class<?>[]{ArrayList.class, DeletedBlocksTransactionSummary.class})) {
         return void.class;
       }
       break;
@@ -164,16 +166,19 @@ public Class<?> getReturnType(String methodName, Class<?>[] parameterTypes) {
       break;
 
     case "reinitialize":
-      if (Arrays.equals(parameterTypes, new Class<?>[]{Table.class, Table.class})) {
+      if (Arrays.equals(parameterTypes,
+          new Class<?>[]{Table.class, Table.class})) {
         return void.class;
       }
       break;
 
     case "removeTransactionsFromDB":
-      if (Arrays.equals(parameterTypes, new Class<?>[]{ArrayList.class})) {
+      if (Arrays.equals(parameterTypes,
+          new Class<?>[]{ArrayList.class})) {
         return void.class;
       }
-      if (Arrays.equals(parameterTypes, new Class<?>[]{ArrayList.class, DeletedBlocksTransactionSummary.class})) {
+      if (Arrays.equals(parameterTypes,
+          new Class<?>[]{ArrayList.class, DeletedBlocksTransactionSummary.class})) {
         return void.class;
       }
       break;

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/invoker/ScmInvokerCodeGenerator.java

@@ -508,22 +508,10 @@ void printReturnTypeIf(Method method) {
       return;
     }
 
-    final String condition =
-        String.format("Arrays.equals(parameterTypes, new Class<?>[]{%s})", params);
-
-    if ((indentation + "if (" + condition + ")").length() <= LINE_LENGTH) {
-      printf("if (%s)", condition);
-      try (UncheckedAutoCloseable ignore = printScope()) {
-        println("return %s.class;", getClassname(method.getReturnType()));
-      }
-    } else {
-      println("if (Arrays.equals(parameterTypes,");
-      try (UncheckedAutoCloseable ignore = printScope(false, 1)) {
-        println("new Class<?>[]{%s}))", params);
-      }
-      try (UncheckedAutoCloseable ignore = printScope()) {
-        println("return %s.class;", getClassname(method.getReturnType()));
-      }
+    println("if (Arrays.equals(parameterTypes,");
+    printf(true, "    new Class<?>[]{%s}))", params);
+    try (UncheckedAutoCloseable ignore = printScope()) {
+      println("return %s.class;", getClassname(method.getReturnType()));
     }
   }