Skip to content

Commit d00a2cf

Browse files
committed
Delete getReturn() method
1 parent 36da113 commit d00a2cf

2 files changed

Lines changed: 0 additions & 56 deletions

File tree

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/invoker/DeletedBlockLogStateManagerInvoker.java

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
import java.io.IOException;
2121
import java.util.ArrayList;
22-
import java.util.Arrays;
2322
import org.apache.hadoop.hdds.protocol.proto.HddsProtos.DeletedBlocksTransactionSummary;
2423
import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.DeletedBlocksTransaction;
2524
import org.apache.hadoop.hdds.scm.block.DeletedBlockLogStateManager;
@@ -146,57 +145,4 @@ public Message invokeLocal(String methodName, Object[] p) throws Exception {
146145

147146
return SCMRatisResponse.encode(returnValue, returnType);
148147
}
149-
150-
@Override
151-
public Class<?> getReturnType(String methodName, Class<?>[] parameterTypes) {
152-
switch (methodName) {
153-
case "addTransactionsToDB":
154-
if (Arrays.equals(parameterTypes,
155-
new Class<?>[]{ArrayList.class})) {
156-
return void.class;
157-
}
158-
if (Arrays.equals(parameterTypes,
159-
new Class<?>[]{ArrayList.class, DeletedBlocksTransactionSummary.class})) {
160-
return void.class;
161-
}
162-
break;
163-
164-
case "getReadOnlyIterator":
165-
if (parameterTypes == null || parameterTypes.length == 0) {
166-
return Table.KeyValueIterator.class;
167-
}
168-
break;
169-
170-
case "onFlush":
171-
if (parameterTypes == null || parameterTypes.length == 0) {
172-
return void.class;
173-
}
174-
break;
175-
176-
case "reinitialize":
177-
if (Arrays.equals(parameterTypes,
178-
new Class<?>[]{Table.class, Table.class})) {
179-
return void.class;
180-
}
181-
break;
182-
183-
case "removeTransactionsFromDB":
184-
if (Arrays.equals(parameterTypes,
185-
new Class<?>[]{ArrayList.class})) {
186-
return void.class;
187-
}
188-
if (Arrays.equals(parameterTypes,
189-
new Class<?>[]{ArrayList.class, DeletedBlocksTransactionSummary.class})) {
190-
return void.class;
191-
}
192-
break;
193-
194-
default:
195-
break;
196-
}
197-
198-
throw new IllegalArgumentException(
199-
"Method not found: " + methodName
200-
+ " with parameterTypes in DeletedBlockLogStateManager");
201-
}
202148
}

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/invoker/ScmInvoker.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ public final Object invoke(String methodName, Object[] args) throws Exception {
6060
return invokeLocal(methodName, args);
6161
}
6262

63-
public abstract Class<?> getReturnType(String methodName, Class<?>[] parameterTypes);
64-
6563
/** For non-@Replicate methods. */
6664
public abstract Message invokeLocal(String methodName, Object[] args) throws Exception;
6765

0 commit comments

Comments
 (0)