Text-to-vector Test Refactoring#4419
Merged
alessandrobenedetti merged 5 commits intoMay 21, 2026
Merged
Conversation
github-actions
Bot
added
documentation
alessandrobenedetti
approved these changes
May 12, 2026
Contributor
alessandrobenedetti
left a comment
alessandrobenedetti
left a comment
There was a problem hiding this comment.
left a couple of minors, once fixed we can merge!
…ectorModelStore.java
aruggero
reviewed
May 14, 2026
Contributor
There was a problem hiding this comment.
@nicolo-rinaldi managedModelStore or managedTextToVectorModelStore as for the document enrichment?
aruggero
reviewed
May 14, 2026
nicolo-rinaldi
force-pushed
the
text-to-vector-test-refactoring
branch
from
3df8074 to
7ea679b
Compare
alessandrobenedetti
approved these changes
May 15, 2026
Contributor
alessandrobenedetti
left a comment
alessandrobenedetti
left a comment
There was a problem hiding this comment.
I'll proceed to merge now
alessandrobenedetti
pushed a commit
that referenced
this pull request
May 21, 2026
(cherry picked from commit d848be3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It turned out that, after the refactoring, some functions and classes were not clear enough. Those have been change to address this issue.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.